Summary: | Animations should use double for key values, not floats | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | CSS | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, glenn, kondapallykalyan, macpherson, menard, ossy, rniwa, simon.fraser | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 120600 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Dean Jackson
2013-08-30 13:36:03 PDT
Created attachment 210157 [details]
Patch
Comment on attachment 210157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210157&action=review > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:69 > + double k = cur.substring(0, cur.length() - 1).toFloat(); Is there a toDouble()? Committed r154909: <http://trac.webkit.org/changeset/154909> (In reply to comment #3) > Committed r154909: <http://trac.webkit.org/changeset/154909> It caused a regression on Coordinated Graphics platforms, the fix is in https://bugs.webkit.org/show_bug.cgi?id=120600 |