Bug 120547

Summary: Animations should use double for key values, not floats
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, kondapallykalyan, macpherson, menard, ossy, rniwa, simon.fraser
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120600    
Bug Blocks:    
Attachments:
Description Flags
Patch simon.fraser: review+

Comment 1 Dean Jackson 2013-08-30 13:39:33 PDT
Created attachment 210157 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-08-30 14:15:32 PDT
Comment on attachment 210157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210157&action=review

> Source/WebCore/css/WebKitCSSKeyframeRule.cpp:69
> +            double k = cur.substring(0, cur.length() - 1).toFloat();

Is there a toDouble()?
Comment 3 Dean Jackson 2013-08-30 14:47:27 PDT
Committed r154909: <http://trac.webkit.org/changeset/154909>
Comment 4 Csaba Osztrogonác 2013-09-02 06:56:01 PDT
(In reply to comment #3)
> Committed r154909: <http://trac.webkit.org/changeset/154909>

It caused a regression on Coordinated Graphics platforms,
the fix is in https://bugs.webkit.org/show_bug.cgi?id=120600