Bug 120547

Summary:

Animations should use double for key values, not floats

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, esprehn+autocc, glenn, kondapallykalyan, macpherson, menard, ossy, rniwa, simon.fraser

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	simon.fraser: review+

Dean Jackson

Reported 2013-08-30 13:36:03 PDT

Attachments
Patch (10.55 KB, patch) 2013-08-30 13:39 PDT, Dean Jackson	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2013-08-30 13:39:33 PDT

Simon Fraser (smfr)

Comment 2 2013-08-30 14:15:32 PDT

Comment on attachment 210157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210157&action=review > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:69 > + double k = cur.substring(0, cur.length() - 1).toFloat(); Is there a toDouble()?

Dean Jackson

Comment 3 2013-08-30 14:47:27 PDT

Csaba Osztrogonác

Comment 4 2013-09-02 06:56:01 PDT

(In reply to comment #3) > Committed r154909: <http://trac.webkit.org/changeset/154909> It caused a regression on Coordinated Graphics platforms, the fix is in https://bugs.webkit.org/show_bug.cgi?id=120600

Note You need to log in before you can comment on or make changes to this bug.