Summary: | [CSS Regions] The layers from the flow thread should be collected under the regions' layers. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Maerean <mmaerean> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Mihai Maerean <mmaerean> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achicu, buildbot, commit-queue, eflews.bot, eric.carlson, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, hyatt, jer.noble, kondapallykalyan, philn, rniwa, simon.fraser, WebkitBugTracker, xan.lopez | ||||||||||||
Priority: | P2 | Keywords: | AdobeTracked | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 121965 | ||||||||||||||
Bug Blocks: | 84900, 123100, 123101 | ||||||||||||||
Attachments: |
|
Description
Mihai Maerean
2013-08-29 01:53:59 PDT
Created attachment 212459 [details]
patch
Comment on attachment 212459 [details]
patch
r=me
Comment on attachment 212459 [details] patch Clearing flags on attachment: 212459 Committed r156451: <http://trac.webkit.org/changeset/156451> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 121965 This broke a number of tests, see <http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r156451%20(12916)/results.html> (except for global constructor failures, which are unrelated). Created attachment 214579 [details] patch that fixes the failing test This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited that only enables compositing for layers inside flow threads that collect the graphics layers under the regions. Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's parent renderer, not in the region renderer (RenderNamedFlowFragment). Comment on attachment 214579 [details] patch that fixes the failing test Attachment 214579 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5378049 Comment on attachment 214579 [details] patch that fixes the failing test Attachment 214579 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.appspot.com/results/5378052 Comment on attachment 214579 [details] patch that fixes the failing test Attachment 214579 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/5408070 Created attachment 214583 [details] patch that fixes the failing test This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited that only enables compositing for layers inside flow threads that collect the graphics layers under the regions. Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's parent renderer, not in the region renderer (RenderNamedFlowFragment). Comment on attachment 214583 [details] patch that fixes the failing test Attachment 214583 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.appspot.com/results/5208016 Comment on attachment 214583 [details] patch that fixes the failing test Attachment 214583 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5238015 Comment on attachment 214583 [details] patch that fixes the failing test Attachment 214583 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5288024 Comment on attachment 214583 [details] patch that fixes the failing test Attachment 214583 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5308025 Comment on attachment 214583 [details] patch that fixes the failing test Attachment 214583 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/5288029 Created attachment 214691 [details] patch that fixes the failing test This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited that only enables compositing for layers inside flow threads that collect the graphics layers under the regions. Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's parent renderer, not in the region renderer (RenderNamedFlowFragment). Comment on attachment 214691 [details] patch that fixes the failing test Attachment 214691 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6148039 Comment on attachment 214691 [details] patch that fixes the failing test Attachment 214691 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6608039 Comment on attachment 214691 [details] patch that fixes the failing test Attachment 214691 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4548118 Comment on attachment 214691 [details] patch that fixes the failing test Attachment 214691 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/6598048 Created attachment 214693 [details] patch that fixes the failing test. the inline keyword was causing the build to fail. This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited that only enables compositing for layers inside flow threads that collect the graphics layers under the regions. Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's parent renderer, not in the region renderer (RenderNamedFlowFragment). Comment on attachment 214693 [details]
patch that fixes the failing test. the inline keyword was causing the build to fail.
r=me
Comment on attachment 214693 [details] patch that fixes the failing test. the inline keyword was causing the build to fail. Clearing flags on attachment: 214693 Committed r157725: <http://trac.webkit.org/changeset/157725> All reviewed patches have been landed. Closing bug. A test added in this commit is failing on the bots: bug 123193 Another layout tests from this patch is still flakily failing on Mac. Filed bug 123220. And another, bug 123282. You should avoid using <video> in layout tests if possible. Doing so always contributes to flakey tests. (In reply to comment #29) > You should avoid using <video> in layout tests if possible. Doing so always contributes to flakey tests. true. tests use events and timers to make sure the 1st frame gets rendered. but still it doesn't work all the time. but you just have to use <video> in a patch for accelerated compositing. plus, the use case of video in regions is what got us into investigating accelerated compositing. |