Bug 120169

Summary: Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 120189    
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[IMAGE] New Context Menus none

Description Joseph Pecoraro 2013-08-22 12:53:09 PDT 
Editor gutters should have a context menu. So you can add / modify breakpoints directly from the sidebar.
Comment 1 Radar WebKit Bug Importer 2013-08-22 12:53:27 PDT 
<rdar://problem/14811085>
Comment 2 Joseph Pecoraro 2013-08-22 13:00:26 PDT 
Created attachment 209385 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2013-08-22 13:01:00 PDT 
Created attachment 209386 [details]
[IMAGE] New Context Menus
Comment 4 Joseph Pecoraro 2013-08-22 13:04:03 PDT 
Comment on attachment 209385 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209385&action=review

> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704
> +            contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this));

Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.
Comment 5 Timothy Hatcher 2013-08-24 09:21:26 PDT 
Comment on attachment 209385 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209385&action=review

>> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704
>> +            contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this));
> 
> Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.

I like Add better.

> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:723
> +            contextMenu.appendItem(WebInspector.UIString("Reveal in Debugger Navigator"), revealInSidebar);

I think Debugger Navigator sounds funny. This would read better as Debugger Navigation Sidebar.
Comment 6 Joseph Pecoraro 2013-08-24 11:57:58 PDT 
Committed <http://trac.webkit.org/changeset/154550>.