Bug 119926

Summary:	Fix background blending for some cases where it did not work at all
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, krit, mihnea, mitica, olaru, simon.fraser
Priority:	P2	Keywords:	BlinkMergeCandidate
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	108546

Description Ryosuke Niwa 2013-08-16 20:09:58 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/b2f5ccbeec231b35e6e1166b7813542e0ab0510c

The fix adds the blendMode parameter to the Image subclass drawing function call, instead of using the default normal blend mode. In some cases this involved adding a new BlendMode parameter to the draw* function. The fixed cases were:
 - background data URI SVG images, when a border-style was added to the container
 - tiled (repeated) gradient backgrounds
 - cross-fade image backgrounds

Comment 1 Mihai Tica 2014-03-04 00:45:43 PST

(In reply to comment #0)
> Consider merging https://chromium.googlesource.com/chromium/blink/+/b2f5ccbeec231b35e6e1166b7813542e0ab0510c
> 
> The fix adds the blendMode parameter to the Image subclass drawing function call, instead of using the default normal blend mode. In some cases this involved adding a new BlendMode parameter to the draw* function. The fixed cases were:
>  - background data URI SVG images, when a border-style was added to the container
>  - tiled (repeated) gradient backgrounds
>  - cross-fade image backgrounds

The patches that address these issues have been submitted in WebKit, this bug can be closed.

Comment 2 Mihnea Ovidenie 2014-03-04 00:57:32 PST

The issues have been fixed with:
https://bugs.webkit.org/show_bug.cgi?id=118894
https://bugs.webkit.org/show_bug.cgi?id=126887
https://bugs.webkit.org/show_bug.cgi?id=126888

This bug can be closed.