|Summary:||Make bug url more human friendly in ChangeLog|
|Product:||WebKit||Reporter:||Dean Jackson <dino>|
|Component:||Tools / Tests||Assignee:||Dean Jackson <dino>|
|Severity:||Normal||CC:||joepeck, ossy, rniwa, thorton|
|Version:||528+ (Nightly build)|
|Bug Depends on:||152898|
Description Dean Jackson 2013-08-13 13:40:52 PDT
Comment 1 Joseph Pecoraro 2013-08-13 13:45:32 PDT
I would even prefer a single line for the bug and bug title, like radars: <http://webkit.org/b/119766> Make bug url more human friendly in ChangeLog That would also make `git log --oneline` history for WebKit way easier to read then the current mess.
Comment 2 Dean Jackson 2013-08-13 13:49:51 PDT
Created attachment 208671 [details] Patch
Comment 3 Dean Jackson 2013-08-13 13:51:03 PDT
OK. Ignore this patch then. BTW, the patch was created with the changes, so webkit-patch works fine.
Comment 4 Dean Jackson 2013-08-13 14:00:22 PDT
Created attachment 208673 [details] Patch
Comment 5 Mark Rowe (bdash) 2013-08-13 14:03:03 PDT
Comment on attachment 208673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208673&action=review > Tools/Scripts/prepare-ChangeLog:198 > + my $bugReadableURL; readableBugURL would be more readable than bugReadableURL.
Comment 6 Dean Jackson 2013-08-13 14:13:13 PDT
Committed r154022: <http://trac.webkit.org/changeset/154022>
Comment 7 Tim Horton 2013-08-21 13:09:44 PDT
This patch broke webkitbot's rollout ability, as it entirely failed to update changelog.py's changelog parsing code. I'm going to fix it in https://bugs.webkit.org/show_bug.cgi?id=120131.
Comment 8 Tim Horton 2013-08-21 13:29:45 PDT
Rolled out in http://trac.webkit.org/changeset/154406.
Comment 9 Ryosuke Niwa 2013-08-21 13:31:29 PDT
There are just too many tools that rely on the old format. Using wekbit.org/b/<~> URL is good but wrapping them in <> and putting the URL and bug title isn't. It makes the long way too long for some bugs and wrapping it in < > breaks all sorts of tools.