Bug 119766

Summary: Make bug url more human friendly in ChangeLog
Product: WebKit Reporter: Dean Jackson <dino>
Component: Tools / TestsAssignee: Dean Jackson <dino>
Status: REOPENED    
Severity: Normal CC: ahmad.saleem792, jbedard, joepeck, ossy, rniwa, ryanhaddad, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152898    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mrowe: review+

Dean Jackson
Reported 2013-08-13 13:40:52 PDT
It's 2013 - we should not be exposing our bugzilla tool URLs to the web when we have a nice redirect already in place. Update prepare-ChangeLog to use https://webkit.org/b/id rather than the longer bugzilla form. The hitch might be to make sure webkit-patch can detect the shorter url.
Attachments
Patch (3.72 KB, patch)
2013-08-13 13:49 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2013-08-13 14:00 PDT, Dean Jackson 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-08-13 13:45:32 PDT
I would even prefer a single line for the bug and bug title, like radars: <http://webkit.org/b/119766> Make bug url more human friendly in ChangeLog That would also make `git log --oneline` history for WebKit way easier to read then the current mess.
Dean Jackson
Comment 2 2013-08-13 13:49:51 PDT
Created attachment 208671 [details] Patch
Dean Jackson
Comment 3 2013-08-13 13:51:03 PDT
OK. Ignore this patch then. BTW, the patch was created with the changes, so webkit-patch works fine.
Dean Jackson
Comment 4 2013-08-13 14:00:22 PDT
Created attachment 208673 [details] Patch
Mark Rowe (bdash)
Comment 5 2013-08-13 14:03:03 PDT
Comment on attachment 208673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208673&action=review > Tools/Scripts/prepare-ChangeLog:198 > + my $bugReadableURL; readableBugURL would be more readable than bugReadableURL.
Dean Jackson
Comment 6 2013-08-13 14:13:13 PDT
Committed r154022: <http://trac.webkit.org/changeset/154022>
Tim Horton
Comment 7 2013-08-21 13:09:44 PDT
This patch broke webkitbot's rollout ability, as it entirely failed to update changelog.py's changelog parsing code. I'm going to fix it in https://bugs.webkit.org/show_bug.cgi?id=120131.
Tim Horton
Comment 8 2013-08-21 13:29:45 PDT
Rolled out in http://trac.webkit.org/changeset/154406.
Ryosuke Niwa
Comment 9 2013-08-21 13:31:29 PDT
There are just too many tools that rely on the old format. Using wekbit.org/b/<~> URL is good but wrapping them in <> and putting the URL and bug title isn't. It makes the long way too long for some bugs and wrapping it in < > breaks all sorts of tools.
Ahmad Saleem
Comment 10 2024-02-24 15:32:18 PST
@Jonathan & Ryan - do we need this now? We still have 'prepare-ChangeLog' script.
Note You need to log in before you can comment on or make changes to this bug.