Bug 119483

Summary: XMLTreeViewer should be created only in the XML viewer mode
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: XMLAssignee: Vivek Galatage <vivekg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2013-08-05 01:45:42 PDT
XMLTreeViewer is created even for the XSL transform. This should be avoided. It should also remove unnecessary conditional check while deciding for XML viewer mode. These patches are already reviewed in blink. Combining these relevant patches into a single patch for webkit. https://codereview.chromium.org/19552003/ https://codereview.chromium.org/22150003/ Patch follows.
Attachments
Patch (6.19 KB, patch)
2013-08-05 01:54 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-08-05 01:54:33 PDT
Created attachment 208112 [details] Patch
Vivek Galatage
Comment 2 2013-08-05 09:00:45 PDT
@ap, thanks for the review.
WebKit Commit Bot
Comment 3 2013-08-05 09:24:52 PDT
Comment on attachment 208112 [details] Patch Clearing flags on attachment: 208112 Committed r153707: <http://trac.webkit.org/changeset/153707>
WebKit Commit Bot
Comment 4 2013-08-05 09:24:54 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2013-08-12 23:47:39 PDT
*** Bug 119723 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.