Bug 119403

Summary:

Crashing Test: fast/forms/color/input-color-onchange-event.html

Product:

WebKit

Reporter:

Ruth Fong <ruthiecftg>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, graouts, jonlee, ruthiecftg, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	commit-queue: review-, thorton: commit-queue-
Patch	none
Patch	none

Ruth Fong

Reported 2013-08-01 10:52:47 PDT

Crashing on mac-wk1 because <input type='color'> is not implemented yet on WK1 (https://bugs.webkit.org/show_bug.cgi?id=119094).

Attachments
Patch (1.97 KB, patch) 2013-08-01 10:59 PDT, Ruth Fong	commit-queue: review- thorton: commit-queue-	Details Formatted Diff Diff
Patch (1.93 KB, application/octet-stream) 2013-08-01 11:30 PDT, Ruth Fong	no flags	Details
Patch (1.93 KB, patch) 2013-08-01 11:31 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ruth Fong

Comment 1 2013-08-01 10:53:25 PDT

<rdar://problem/14621667>

Radar WebKit Bug Importer

Comment 2 2013-08-01 10:53:46 PDT

<rdar://problem/14621833>

Ruth Fong

Comment 3 2013-08-01 10:59:16 PDT

Created attachment 207938 [details] Patch

Tim Horton

Comment 4 2013-08-01 11:19:59 PDT

Comment on attachment 207938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207938&action=review > LayoutTests/platform/mac-wk2/TestExpectations:118 > +fast/forms/color/input-color-onchange-event.html [ Pass ] There's a section down at the bottom titled "Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here". Please put this there. Also check if there's something similar for the other one.

Tim Horton

Comment 5 2013-08-01 11:23:28 PDT

(In reply to comment #1) > <rdar://problem/14621667> We're using this one ^^.

WebKit Commit Bot

Comment 6 2013-08-01 11:27:00 PDT

Comment on attachment 207938 [details] Patch Rejecting attachment 207938 [details] from review queue. graouts@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.

Ruth Fong

Comment 7 2013-08-01 11:30:19 PDT

Created attachment 207940 [details] Patch

Ruth Fong

Comment 8 2013-08-01 11:31:41 PDT

Created attachment 207941 [details] Patch

WebKit Commit Bot

Comment 9 2013-08-01 11:57:17 PDT

Comment on attachment 207941 [details] Patch Clearing flags on attachment: 207941 Committed r153594: <http://trac.webkit.org/changeset/153594>

WebKit Commit Bot

Comment 10 2013-08-01 11:57:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.