Bug 119403 - Crashing Test: fast/forms/color/input-color-onchange-event.html
Summary: Crashing Test: fast/forms/color/input-color-onchange-event.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2013-08-01 10:52 PDT by Ruth Fong
Modified: 2013-08-01 11:57 PDT (History)
7 users (show)

See Also:

Patch (1.97 KB, patch)
2013-08-01 10:59 PDT, Ruth Fong
commit-queue: review-
thorton: commit-queue-
Details | Formatted Diff | Diff
Patch (1.93 KB, application/octet-stream)
2013-08-01 11:30 PDT, Ruth Fong
no flags Details
Patch (1.93 KB, patch)
2013-08-01 11:31 PDT, Ruth Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ruth Fong 2013-08-01 10:52:47 PDT
Crashing on mac-wk1 because <input type='color'> is not implemented yet on WK1 (https://bugs.webkit.org/show_bug.cgi?id=119094).
Comment 1 Ruth Fong 2013-08-01 10:53:25 PDT
Comment 2 Radar WebKit Bug Importer 2013-08-01 10:53:46 PDT
Comment 3 Ruth Fong 2013-08-01 10:59:16 PDT
Created attachment 207938 [details]
Comment 4 Tim Horton 2013-08-01 11:19:59 PDT
Comment on attachment 207938 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=207938&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:118
> +fast/forms/color/input-color-onchange-event.html [ Pass ]

There's a section down at the bottom titled "Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here". Please put this there. Also check if there's something similar for the other one.
Comment 5 Tim Horton 2013-08-01 11:23:28 PDT
(In reply to comment #1)
> <rdar://problem/14621667>

We're using this one ^^.
Comment 6 WebKit Commit Bot 2013-08-01 11:27:00 PDT
Comment on attachment 207938 [details]

Rejecting attachment 207938 [details] from review queue.

graouts@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 7 Ruth Fong 2013-08-01 11:30:19 PDT
Created attachment 207940 [details]
Comment 8 Ruth Fong 2013-08-01 11:31:41 PDT
Created attachment 207941 [details]
Comment 9 WebKit Commit Bot 2013-08-01 11:57:17 PDT
Comment on attachment 207941 [details]

Clearing flags on attachment: 207941

Committed r153594: <http://trac.webkit.org/changeset/153594>
Comment 10 WebKit Commit Bot 2013-08-01 11:57:20 PDT
All reviewed patches have been landed.  Closing bug.