Summary: | Fix problem with find-resolved-bugs command | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Seokju Kwon <seokju> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | UNCONFIRMED --- | ||||||||||||
Severity: | Normal | CC: | abrhm, cdumez, commit-queue, dpranke, eflews.bot, glenn, gyuyoung.kim, ossy, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Seokju Kwon
2013-08-01 01:29:20 PDT
Created attachment 207905 [details]
Patch
@Ossy Could you please take a look at this? Created attachment 208397 [details]
Patch
Sync with the latest code. CC'ing rniwa. Comment on attachment 208397 [details] Patch Attachment 208397 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1359358 It is not related to this patch.(In reply to comment #5) > (From update of attachment 208397 [details]) > Attachment 208397 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/1359358 Not related to this patch. Comment on attachment 208397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208397&action=review > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > + notPermitted_ids = set() not_permitted_ids Created attachment 208402 [details]
Patch
(In reply to comment #7) > (From update of attachment 208397 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208397&action=review > > > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > > + notPermitted_ids = set() > > not_permitted_ids @Christophe Dumez Fixed. Thanks :-) Comment on attachment 208402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > + # Avoid authentication What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > + not_Permitted_ids = set() without capital letters : not_permitted_ids. (In reply to comment #10) > (From update of attachment 208402 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > > + # Avoid authentication > > What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? It might be better to just not abort when authentication fails, and ignore that bug instead. (In reply to comment #10) > (From update of attachment 208402 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > > + # Avoid authentication > > What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? > This patch avoided requiring authentication if bugs have restricted accesses. But It could be checked manually with 'not_permitted_ids' links. > > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > > + not_Permitted_ids = set() > > without capital letters : not_permitted_ids. Oh my bad. (In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 208402 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > > > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > > > + # Avoid authentication > > > > What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? > > It might be better to just not abort when authentication fails, and ignore that bug instead. I will upload a new patch. Thanks. Created attachment 208508 [details]
Patch
Comment on attachment 208508 [details]
Patch
Assuming that patches for review since 2013 are stale, r-
|