Bug 42457 – Web Inspector: should be possible to convert console message arguments to InspectorValues

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: should be possible to convert console message arguments to InspectorValues. This is a bit different from other back end<->front end message parameters in that it should be built from VM-specific JS object residing in the inspected page context.

[Yury Semikhatsky]

Created attachment 62285 [details]
Patch

[Pavel Feldman]

Comment on attachment 62285 [details]
Patch

r+ with comments. Please fix prior to landing.

[Pavel Feldman]

Comment on attachment 62285 [details]
Patch

WebCore/bindings/js/ScriptValue.cpp:145
 +      return 0;
Regex is lost here. Consider running toString by default.

WebCore/inspector/ConsoleMessage.h:55
 +      void addToFrontend(RemoteInspectorFrontend*, InjectedScriptHost*);
Bring InspectorFrontend2 back!

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 62285 [details])
> WebCore/bindings/js/ScriptValue.cpp:145
>  +      return 0;
> Regex is lost here. Consider running toString by default.
>
That is fine that it's lost,  JSON.stringify(new RegExp(...)) will always return undefined. It's caller responsibility to prepare a convertible object.

> WebCore/inspector/ConsoleMessage.h:55
>  +      void addToFrontend(RemoteInspectorFrontend*, InjectedScriptHost*);
> Bring InspectorFrontend2 back!
What do you mean?

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptValue.cpp
	M	WebCore/bindings/js/ScriptValue.h
	M	WebCore/bindings/v8/ScriptValue.cpp
	M	WebCore/bindings/v8/ScriptValue.h
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/ConsoleMessage.h
	M	WebCore/inspector/InjectedScript.cpp
	M	WebCore/inspector/InjectedScript.h
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/inspector.js
Committed r63891