Bug 119029
| Summary: | Fix HTMLMediaElement so that it doesn't add cues for disabled text tracks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/3aed1192f832e597e96c4f7695b7ab8d3a2339eb
This patch reverts the change to TextTrackCue added in
https://src.chromium.org/viewvc/blink?revision=153206&view=revision
and addresses the actual underlying issue. The real problem
is that HTMLMediaElement was allowing cues from disabled
tracks to be added to m_cueTree under certain
circumstances. This patch adds checks to textTrackAddCues()
and textTrackAddCue() to prevent disabled track cues from
being added.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Carlson
(In reply to comment #0)
> Consider merging https://chromium.googlesource.com/chromium/blink/+/3aed1192f832e597e96c4f7695b7ab8d3a2339eb
>
> This patch reverts the change to TextTrackCue added in
> https://src.chromium.org/viewvc/blink?revision=153206&view=revision
> and addresses the actual underlying issue. The real problem
> is that HTMLMediaElement was allowing cues from disabled
> tracks to be added to m_cueTree under certain
> circumstances. This patch adds checks to textTrackAddCues()
> and textTrackAddCue() to prevent disabled track cues from
> being added.
I merged this change in r152721. You reviewed it ;-)
*** This bug has been marked as a duplicate of bug 118682 ***