Bug 118845

Summary: Simplify SVG animated type handling in the JSC bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, haraken, laszlo.gombos, rniwa
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 118877    
Bug Blocks: 125670    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-07-18 05:17:04 PDT
We can simplify SVG animated type handling in the JSC bindings generator, especially in these subroutines: - IsSVGAnimatedType() - GetterExpression() Corresponding Blink revisions: https://src.chromium.org/viewvc/blink?revision=154286&view=revision https://src.chromium.org/viewvc/blink?revision=154389&view=revision
Attachments
Patch (4.17 KB, patch)
2013-07-18 05:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-18 05:23:18 PDT
Created attachment 206983 [details] Patch
Kentaro Hara
Comment 2 2013-07-18 05:46:53 PDT
Comment on attachment 206983 [details] Patch ok
WebKit Commit Bot
Comment 3 2013-07-18 07:50:37 PDT
Comment on attachment 206983 [details] Patch Clearing flags on attachment: 206983 Committed r152845: <http://trac.webkit.org/changeset/152845>
WebKit Commit Bot
Comment 4 2013-07-18 07:50:40 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2013-12-12 18:05:34 PST
Comment on attachment 206983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206983&action=review > Source/WebCore/bindings/scripts/CodeGenerator.pm:575 > + } elsif ($generator->IsSVGAnimatedType($attribute)) { This is wrong. $attribute in this context is a hash, not a string that can be compared. I think this test now always fails, causing us to use "fastGetAttribute" in some cases where it is not safe. This should have been something like: "my $type = $attribute->signature->type; if ($generator->IsSVGAniatedType($type)) { ... do stuff
Note You need to log in before you can comment on or make changes to this bug.