Bug 118845

Summary: Simplify SVG animated type handling in the JSC bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, haraken, laszlo.gombos, rniwa
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 118877    
Bug Blocks: 125670    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2013-07-18 05:17:04 PDT 
We can simplify SVG animated type handling in the JSC bindings generator, especially in these subroutines:
- IsSVGAnimatedType()
- GetterExpression()

Corresponding Blink revisions:
https://src.chromium.org/viewvc/blink?revision=154286&view=revision
https://src.chromium.org/viewvc/blink?revision=154389&view=revision
Comment 1 Chris Dumez 2013-07-18 05:23:18 PDT 
Created attachment 206983 [details]
Patch
Comment 2 Kentaro Hara 2013-07-18 05:46:53 PDT 
Comment on attachment 206983 [details]
Patch

ok
Comment 3 WebKit Commit Bot 2013-07-18 07:50:37 PDT 
Comment on attachment 206983 [details]
Patch

Clearing flags on attachment: 206983

Committed r152845: <http://trac.webkit.org/changeset/152845>
Comment 4 WebKit Commit Bot 2013-07-18 07:50:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2013-12-12 18:05:34 PST 
Comment on attachment 206983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206983&action=review

> Source/WebCore/bindings/scripts/CodeGenerator.pm:575
> +        } elsif ($generator->IsSVGAnimatedType($attribute)) {

This is wrong. $attribute in this context is a hash, not a string that can be compared.  I think this test now always fails, causing us to use "fastGetAttribute" in some cases where it is not safe.

This should have been something like:

"my $type = $attribute->signature->type; 
if ($generator->IsSVGAniatedType($type)) {
... do stuff