Bug 118684

Summary: compositionstart event should contain the text to be replaced
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, ap, buildbot, darin, enrica, rniwa, tkent
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=248367
Bug Depends on:    
Bug Blocks: 118688    
Attachments:
Description Flags
Fixes the bug
none
Test case
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Description Ryosuke Niwa 2013-07-15 14:32:34 PDT
Merge https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d to match IE and Firefox behaviors.
Comment 1 Ryosuke Niwa 2013-07-15 14:45:48 PDT
Created attachment 206686 [details]
Fixes the bug
Comment 2 Alexey Proskuryakov 2013-07-15 14:51:22 PDT
Comment on attachment 206686 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=206686&action=review

> Source/WebCore/ChangeLog:14
> +        According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
> +        to the specified behavior.

Could you please test Firefox on Mac?
Comment 3 Ryosuke Niwa 2013-07-15 14:59:09 PDT
Created attachment 206688 [details]
Test case

(In reply to comment #2)
> (From update of attachment 206686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206686&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
> > +        to the specified behavior.
> 
> Could you please test Firefox on Mac?

Confirmed on Firefox 21.
Comment 4 Build Bot 2013-07-15 15:40:01 PDT
Comment on attachment 206686 [details]
Fixes the bug

Attachment 206686 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1065960

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html
Comment 5 Build Bot 2013-07-15 15:40:03 PDT
Created attachment 206695 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 6 Ryosuke Niwa 2013-07-15 16:28:05 PDT
Comment on attachment 206686 [details]
Fixes the bug

Clearing flags on attachment: 206686

Committed r152668: <http://trac.webkit.org/changeset/152668>
Comment 7 Ryosuke Niwa 2013-07-15 16:28:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ahmad Saleem 2022-11-28 05:02:07 PST
*** Bug 248367 has been marked as a duplicate of this bug. ***