| Summary: | HTMLMediaElement should not add cues for disabled text tracks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jer.noble, rniwa, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2013-07-15 12:40:02 PDT
Created attachment 206682 [details]
Proposed patch
Comment on attachment 206682 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=206682&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1490 > -void HTMLMediaElement::textTrackAddCues(TextTrack*, const TextTrackCueList* cues) > +void HTMLMediaElement::textTrackAddCues(TextTrack* track, const TextTrackCueList* cues) Would it make sense for this function to take PassRefPtr<TextTrack> instead to be safe? (In reply to comment #3) > (From update of attachment 206682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206682&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:1490 > > -void HTMLMediaElement::textTrackAddCues(TextTrack*, const TextTrackCueList* cues) > > +void HTMLMediaElement::textTrackAddCues(TextTrack* track, const TextTrackCueList* cues) > > Would it make sense for this function to take PassRefPtr<TextTrack> instead to be safe? Maybe. These functions are part of a larger interface used by a number of other classes so that will be a much bigger change, so I will do it in a separate patch if it does make sense. Committed r152721: http://trac.webkit.org/changeset/152721 *** Bug 119029 has been marked as a duplicate of this bug. *** |