Bug 118638
| Summary: | Flexbox: Rename various variables and arguments to match the naming from the spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ahmad.saleem792, bdakin, dino, hyatt, sgill26, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/4a723f1500205a05096946476bdc84b56a24f90f
This should make it easier to understand the code. I have also
simplified some calculations and gave some expressions their own
variables.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
@Sam - is this applicable anymore?
Sammy Gill
Looking at both the patch in question and the current code I don't think so. Looks like we merged in those changes and some others when we rebased the flex code off of Blink's ToT a while ago: https://bugs.webkit.org/show_bug.cgi?id=168657
Sammy Gill
Going to go ahead and resolve this since it was already taken care of by the rebase we did a while back
*** This bug has been marked as a duplicate of bug 168657 ***