Summary: | Remove ElementTimeControl and expose SVGAnimationElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | SVG | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, benjamin, commit-queue, darin, d-r, esprehn+autocc, fmalita, gyuyoung.kim, haraken, krit, laszlo.gombos, pdr, rakuco, rniwa, rwlbuis, schenney, thorton, timothy, zimmermann | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, WebExposed | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 118353 | ||||||
Attachments: |
|
Description
Chris Dumez
2013-07-03 03:05:15 PDT
Created attachment 205990 [details]
Patch
Comment on attachment 205990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review > Source/WebCore/svg/ElementTimeControl.idl:-30 > - ObjCProtocol, Looks like you removed [ObjCProtocol]. Is it OK? Comment on attachment 205990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review >> Source/WebCore/svg/ElementTimeControl.idl:-30 >> - ObjCProtocol, > > Looks like you removed [ObjCProtocol]. Is it OK? Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least there is that. (In reply to comment #3) > (From update of attachment 205990 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review > > >> Source/WebCore/svg/ElementTimeControl.idl:-30 > >> - ObjCProtocol, > > > > Looks like you removed [ObjCProtocol]. Is it OK? > > Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least > there is that. Could someone who understand Objective C bindings confirm that this change is OK please? Comment on attachment 205990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review >>>> Source/WebCore/svg/ElementTimeControl.idl:-30 >>>> - ObjCProtocol, >>> >>> Looks like you removed [ObjCProtocol]. Is it OK? >> >> Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least >> there is that. > > Could someone who understand Objective C bindings confirm that this change is OK please? It is fine. We don't generate the ObjC DOM for SVG anymore. (In reply to comment #5) > (From update of attachment 205990 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205990&action=review > > >>>> Source/WebCore/svg/ElementTimeControl.idl:-30 > >>>> - ObjCProtocol, > >>> > >>> Looks like you removed [ObjCProtocol]. Is it OK? > >> > >> Well, this extended attribute only applies to this interface (not the children). Since this interface is removed, I think it is OK. However, someone from the mac port should probably confirm as I am not familiar with the ObjC bindings. The mac ews are green so at least > >> there is that. > > > > Could someone who understand Objective C bindings confirm that this change is OK please? > > It is fine. We don't generate the ObjC DOM for SVG anymore. Thanks for looking Timothy. Comment on attachment 205990 [details]
Patch
Looks good.
Comment on attachment 205990 [details] Patch Clearing flags on attachment: 205990 Committed r152543: <http://trac.webkit.org/changeset/152543> All reviewed patches have been landed. Closing bug. |