Summary: | iframe constrained by max-width in full screen | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brad Dougherty <me> | ||||||
Component: | Frames | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ddkilzer, eoconnor, eric.carlson, esprehn+autocc, glenn, jer.noble, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.8 | ||||||||
URL: | http://brad.is/reportingbugs/maxwidth/ | ||||||||
Attachments: |
|
Description
Brad Dougherty
2013-07-01 08:43:43 PDT
Created attachment 206147 [details]
Patch
Comment on attachment 206147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206147&action=review > Source/WebCore/css/fullscreen.css:56 > + max-width: none !important; > + max-height: none !important; > } Should this be done for all :-webkit-full-screen elements instead of just iframe? Created attachment 206149 [details]
Patch
Comment on attachment 206149 [details]
Patch
r=me
Comment on attachment 206149 [details] Patch Clearing flags on attachment: 206149 Committed r152424: <http://trac.webkit.org/changeset/152424> All reviewed patches have been landed. Closing bug. LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix. (In reply to comment #8) > LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix. tracking at bug 118842 (In reply to comment #9) > (In reply to comment #8) > > LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix. > > tracking at bug 118842 and by bug 118842, I meant bug 118820 |