Bug 118250

Summary: iframe constrained by max-width in full screen
Product: WebKit Reporter: Brad Dougherty <me>
Component: FramesAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, eoconnor, eric.carlson, esprehn+autocc, glenn, jer.noble, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.8   
URL: http://brad.is/reportingbugs/maxwidth/
Attachments:
Description Flags
Patch
none
Patch none

Description Brad Dougherty 2013-07-01 08:43:43 PDT
Overview: 
When a max-width style is applied to an iframe, the constraint persists when an element inside the iframe is put into full screen.

Steps to Reproduce:
1) Go to http://brad.is/reportingbugs/maxwidth/
2) Click on the full screen button

Actual Results:
The element has a max-width of 700px (as defined on the iframe), and the rest of the page contents show in the remaining space.

Expected Results:
The contents of the iframe should fill the entire screen.

Build Date & Platform:
Confirmed that it is happening in Safari 7.0 (9537.46.5) and Safari 6.0.5.
Verified that Firefox 22 has the correct behavior.
Comment 1 zalan 2013-07-05 07:13:35 PDT
Created attachment 206147 [details]
Patch
Comment 2 Antti Koivisto 2013-07-05 07:20:44 PDT
Comment on attachment 206147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206147&action=review

> Source/WebCore/css/fullscreen.css:56
> +    max-width: none !important;
> +    max-height: none !important;
>  }

Should this be done for all :-webkit-full-screen elements instead of just iframe?
Comment 3 zalan 2013-07-05 07:52:06 PDT
Created attachment 206149 [details]
Patch
Comment 4 Antti Koivisto 2013-07-05 07:53:40 PDT
Comment on attachment 206149 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-07-05 14:29:11 PDT
Comment on attachment 206149 [details]
Patch

Clearing flags on attachment: 206149

Committed r152424: <http://trac.webkit.org/changeset/152424>
Comment 6 WebKit Commit Bot 2013-07-05 14:29:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 David Kilzer (:ddkilzer) 2013-07-05 14:49:06 PDT
<rdar://problem/14364906>
Comment 8 Simon Fraser (smfr) 2013-07-17 18:12:47 PDT
LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.
Comment 9 zalan 2013-07-18 04:35:36 PDT
(In reply to comment #8)
> LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.

tracking at bug 118842
Comment 10 zalan 2013-07-18 08:39:22 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.
> 
> tracking at bug 118842
and by bug 118842, I meant bug 118820