Bug 118243

Summary: [CSS Blending] Add test suite to validate background blending with different properties
Product: WebKit Reporter: Mirela <mbudaes>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, krit, rniwa, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108546    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Patch
none
Patch
none
Patch none

Description Mirela 2013-07-01 06:46:01 PDT
Add tests to validate background bending with the following properties:
1. Blend a background image and a background color specifying background-position in percentage, such as 50% 50%
2. Blend a background image and a background color specifying background-size in pixels 
3. Blend a background image and a background color specifying background-size in percentage
4. Blend a background image and a background color specifying background-size: cover 
5. Blend a background image and a background color specifying background-size: contain 
6. Blend a background image and a background color specifying background-repeat: no-repeat 
7. Blend a background image and a background color specifying background-clip: padding-box 
8. Blend a background image and a background color specifying background-clip: content-box 
9. Blend a background image and a background color specifying background-origin: border-box 
10. Blend a background image and a background color specifying background-origin: content-box 
11. Blend a background image and a background color specifying background-attachment: fixed
Comment 1 Mirela 2013-07-01 07:06:51 PDT
Created attachment 205810 [details]
Patch
Comment 2 Mirela 2013-07-02 06:47:02 PDT
Created attachment 205906 [details]
Patch
Comment 3 Build Bot 2013-07-02 07:52:27 PDT
Comment on attachment 205906 [details]
Patch

Attachment 205906 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1014527

New failing tests:
media/video-zoom.html
Comment 4 Build Bot 2013-07-02 07:52:29 PDT
Created attachment 205915 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 5 Mirela 2013-07-04 09:11:31 PDT
Created attachment 206096 [details]
Patch
Comment 6 Dirk Schulze 2013-07-16 06:39:48 PDT
Comment on attachment 206096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206096&action=review

> LayoutTests/css3/compositing/background-blend-mode-background-attachement-fixed.html:7
> +	background: url('resources/ducky.png'), green;

Do you think it would be possible to use a dataURI of SVG with one color instead? This could make it possible to use ref tests instead of pixel tests.
Comment 7 Mirela 2013-07-29 09:13:23 PDT
(In reply to comment #6)
> (From update of attachment 206096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206096&action=review
> 
> > LayoutTests/css3/compositing/background-blend-mode-background-attachement-fixed.html:7
> > +	background: url('resources/ducky.png'), green;
> 
> Do you think it would be possible to use a dataURI of SVG with one color instead? This could make it possible to use ref tests instead of pixel tests.

I've tried to use dataURI of SVG but using feBlend in the expected svg file resulted in colour differences between the css blending and the svg feBlend results. I can attach a patch with a simple ref test that I have used.
Comment 8 Mirela 2013-08-07 05:28:03 PDT
Created attachment 208254 [details]
Patch
Comment 9 Dirk Schulze 2013-08-07 05:47:15 PDT
Comment on attachment 208254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208254&action=review

r=me.

> LayoutTests/css3/compositing/background-blend-mode-background-size-cover-expected.html:8
> +	background-size: cover;

this shouldn't be necessary for background-color. After all this is the expected file.
Comment 10 Mirela 2013-08-07 05:54:15 PDT
Created attachment 208260 [details]
Patch
Comment 11 WebKit Commit Bot 2013-08-07 06:41:44 PDT
Comment on attachment 208260 [details]
Patch

Clearing flags on attachment: 208260

Committed r153784: <http://trac.webkit.org/changeset/153784>
Comment 12 WebKit Commit Bot 2013-08-07 06:41:48 PDT
All reviewed patches have been landed.  Closing bug.