Bug 118089

Summary: [CSS Shapes] New positioning model: Positive margins
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior
Bug Depends on: 121614, 121808    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
none
Patch none

Description Bem Jones-Bey 2013-06-26 14:50:07 PDT
Test support for positive margins on the float and fix any implementation issues.
Comment 1 Bem Jones-Bey 2013-06-26 14:54:03 PDT
Tests:

[ ]positive top margin
[ ]positive left margin
[ ]positive right margin
[ ]positive bottom margin
[ ]positive left margin right-left writing mode
[ ]positive right margin right-left writing mode
[ ]positive top margin vertical right-left writing mode
[ ]positive left margin vertical right-left writing mode
[ ]positive right margin vertical right-left writing mode
[ ]positive bottom margin vertical right-left writing mode
[ ]positive top margin vertical left-right writing mode
[ ]positive left margin vertical left-right writing mode
[ ]positive right margin vertical rleft-right writing mode
[ ]positive bottom margin vertical left-right writing mode
Comment 2 Bem Jones-Bey 2013-09-27 16:27:43 PDT
Created attachment 212852 [details]
Patch

Tests that were not covered by the fixes in bugs that this bug depends on
Comment 3 Bem Jones-Bey 2013-09-27 16:39:50 PDT
Created attachment 212853 [details]
Patch

Fix error in one test
Comment 4 Alexandru Chiculita 2013-09-27 16:42:15 PDT
Comment on attachment 212853 [details]
Patch

Cool!
Comment 5 WebKit Commit Bot 2013-09-27 17:31:08 PDT
Comment on attachment 212853 [details]
Patch

Clearing flags on attachment: 212853

Committed r156593: <http://trac.webkit.org/changeset/156593>
Comment 6 WebKit Commit Bot 2013-09-27 17:31:10 PDT
All reviewed patches have been landed.  Closing bug.