Bug 121808 - Properly handle bottom margin on float with shape-outside
Summary: Properly handle bottom margin on float with shape-outside
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks: 118089
  Show dependency tree / graph
 
Reported: 2013-09-23 15:38 PDT by Bem Jones-Bey
Modified: 2013-09-24 12:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.07 KB, patch)
2013-09-23 15:40 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Fix review feedback (20.45 KB, patch)
2013-09-24 10:44 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Rebase (20.40 KB, patch)
2013-09-24 11:27 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-09-23 15:38:09 PDT 
Properly handle bottom margin on float with shape-outside
Comment 1 Bem Jones-Bey 2013-09-23 15:40:59 PDT 
Created attachment 212400 [details]
Patch
Comment 2 Dave Hyatt 2013-09-24 09:39:16 PDT 
Comment on attachment 212400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212400&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3754
> +            floatBottom = r->y() + marginBeforeForChild(r->renderer()) + shapeOutside->shapeLogicalBottom();

y() is wrong here. Let's get a vertical test, which will show why it's wrong. :)
Comment 3 Bem Jones-Bey 2013-09-24 10:44:29 PDT 
Created attachment 212480 [details]
Fix review feedback

Duh. Yeah, I should have been using logical coordinates. FIxed, and one more test added.
Comment 4 Dave Hyatt 2013-09-24 11:16:29 PDT 
Comment on attachment 212480 [details]
Fix review feedback

r=me
Comment 5 Bem Jones-Bey 2013-09-24 11:27:29 PDT 
Created attachment 212484 [details]
Rebase
Comment 6 WebKit Commit Bot 2013-09-24 12:01:49 PDT 
Comment on attachment 212484 [details]
Rebase

Clearing flags on attachment: 212484

Committed r156346: <http://trac.webkit.org/changeset/156346>
Comment 7 WebKit Commit Bot 2013-09-24 12:01:52 PDT 
All reviewed patches have been landed.  Closing bug.