Bug 121614 - [CSS Shapes] Fix handling of top margin on float with shape-outside
Summary: [CSS Shapes] Fix handling of top margin on float with shape-outside
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks: 118089
  Show dependency tree / graph
 
Reported: 2013-09-19 09:45 PDT by Bem Jones-Bey
Modified: 2013-09-19 11:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.56 KB, patch)
2013-09-19 09:48 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Updated patch (17.64 KB, patch)
2013-09-19 11:00 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-09-19 09:45:55 PDT 
Fix handling of top margin on float with shape-outside
Comment 1 Bem Jones-Bey 2013-09-19 09:48:30 PDT 
Created attachment 212078 [details]
Patch
Comment 2 Alexandru Chiculita 2013-09-19 10:15:10 PDT 
Comment on attachment 212078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212078&action=review

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:61
> +    LayoutUnit marginBefore = containingBlock->marginBeforeForChild(m_renderer);
> +    if (marginBefore < 0)
> +        marginBefore = LayoutUnit();

nit: might look better to use the max(0, value) function instead.
Comment 3 Bem Jones-Bey 2013-09-19 11:00:39 PDT 
Created attachment 212081 [details]
Updated patch

Update for review feedback
Comment 4 WebKit Commit Bot 2013-09-19 11:17:35 PDT 
Comment on attachment 212081 [details]
Updated patch

Clearing flags on attachment: 212081

Committed r156106: <http://trac.webkit.org/changeset/156106>
Comment 5 WebKit Commit Bot 2013-09-19 11:17:37 PDT 
All reviewed patches have been landed.  Closing bug.