Bug 118071

Summary: Remove [NoInterfaceObject] from WorkerGlobalScope
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, darin, haraken, laszlo.gombos
Priority: P2 Keywords: BlinkMergeCandidate, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope
Bug Depends on: 118059    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch none

Description Chris Dumez 2013-06-26 11:26:40 PDT
According to the latest specification, WorkerGlobalScope, SharedWorkerGlobalScope and DedicatedWorkerGlobalScope should not have [NoInterfaceObject]:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

They need to be exposed only in specific environments so removing [NoInterfaceObject] is not enough. Extending the [GlobalContext] extended attribute is needed as well.

Corresponding Blink patch:
https://src.chromium.org/viewvc/blink?revision=153070&view=revision
Comment 1 Chris Dumez 2013-06-27 04:44:44 PDT
Created attachment 205587 [details]
WIP Patch
Comment 2 Chris Dumez 2013-06-27 06:22:57 PDT
Created attachment 205596 [details]
Patch
Comment 3 Kentaro Hara 2013-06-27 06:44:11 PDT
Comment on attachment 205596 [details]
Patch

The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch.
Comment 4 Chris Dumez 2013-06-27 06:51:04 PDT
(In reply to comment #3)
> (From update of attachment 205596 [details])
> The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch.

Yes, the result is the same:
- WorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a worker environment.
- DedicatedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a dedicated worker environment.
- SharedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a shared worker environment.
Comment 5 WebKit Commit Bot 2013-06-27 08:47:11 PDT
Comment on attachment 205596 [details]
Patch

Clearing flags on attachment: 205596

Committed r152100: <http://trac.webkit.org/changeset/152100>
Comment 6 WebKit Commit Bot 2013-06-27 08:47:13 PDT
All reviewed patches have been landed.  Closing bug.