Bug 118071

Summary:

Remove [NoInterfaceObject] from WorkerGlobalScope

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, commit-queue, darin, haraken, laszlo.gombos

Priority:

Keywords:

BlinkMergeCandidate, WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

Bug Depends on:

118059

Bug Blocks:

Attachments:

Description	Flags
WIP Patch	none
Patch	none

Chris Dumez

Reported 2013-06-26 11:26:40 PDT

According to the latest specification, WorkerGlobalScope, SharedWorkerGlobalScope and DedicatedWorkerGlobalScope should not have [NoInterfaceObject]: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope They need to be exposed only in specific environments so removing [NoInterfaceObject] is not enough. Extending the [GlobalContext] extended attribute is needed as well. Corresponding Blink patch: https://src.chromium.org/viewvc/blink?revision=153070&view=revision

Attachments
WIP Patch (200.65 KB, patch) 2013-06-27 04:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (203.98 KB, patch) 2013-06-27 06:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-06-27 04:44:44 PDT

Created attachment 205587 [details] WIP Patch

Chris Dumez

Comment 2 2013-06-27 06:22:57 PDT

Created attachment 205596 [details] Patch

Kentaro Hara

Comment 3 2013-06-27 06:44:11 PDT

Comment on attachment 205596 [details] Patch The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch.

Chris Dumez

Comment 4 2013-06-27 06:51:04 PDT

(In reply to comment #3) > (From update of attachment 205596 [details]) > The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch. Yes, the result is the same: - WorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a worker environment. - DedicatedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a dedicated worker environment. - SharedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a shared worker environment.

WebKit Commit Bot

Comment 5 2013-06-27 08:47:11 PDT

Comment on attachment 205596 [details] Patch Clearing flags on attachment: 205596 Committed r152100: <http://trac.webkit.org/changeset/152100>

WebKit Commit Bot

Comment 6 2013-06-27 08:47:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.