Bug 117853

Summary:

WebGL files not included in Windows build (take 2)

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, dino, eflews.bot, gtk-ews, gyuyoung.kim, noam, rego+ews, rniwa, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2013-06-20 16:52:30 PDT

https://bugs.webkit.org/show_bug.cgi?id=117809 was rolled out in r151770 because it broke the Windows build after all. This patch is trying to do the same thing, that is, include the WebGL source files in the Windows build. This time I copy the necessary headers and fix a syntax error in LoopBlinnShader.cpp that has been broken and unused for a while.

Attachments
Patch (48.28 KB, patch) 2013-06-20 17:00 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (48.87 KB, patch) 2013-06-21 09:59 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (48.88 KB, patch) 2013-06-21 10:57 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (50.01 KB, patch) 2013-06-21 11:21 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (50.49 KB, patch) 2013-06-21 13:07 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-06-20 17:00:25 PDT

Created attachment 205129 [details] Patch

Build Bot

Comment 2 2013-06-20 20:18:14 PDT

Comment on attachment 205129 [details] Patch Attachment 205129 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/884381

Brent Fulgham

Comment 3 2013-06-21 09:52:15 PDT

Comment on attachment 205129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205129&action=review Looks good. I'm going to try building it locally. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:148 > + <ClCompile Include="$(ConfigurationBuildDir)\obj32\WebCore\DerivedSources\JSEXTDrawBuffers.cpp"> I hate how Visual Studio creates all this solution/project file churn.

Alex Christensen

Comment 4 2013-06-21 09:59:42 PDT

Created attachment 205195 [details] Patch

Brent Fulgham

Comment 5 2013-06-21 10:52:57 PDT

Comment on attachment 205195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205195&action=review > Source/WebCore/WebCore.vcxproj/WebCorePreBuild.cmd:7 > +xcopy %WEBKIT_SOURCE%\ThirdParty\ANGLE\include %CONFIGURATIONBUILDDIR%\include /s You should put both path arguments to xcopy in quotes so that the build doesn't break if someone uses a path with spaces in it.

Alex Christensen

Comment 6 2013-06-21 10:57:27 PDT

Created attachment 205199 [details] Patch

Alex Christensen

Comment 7 2013-06-21 11:21:32 PDT

Created attachment 205202 [details] Patch

Build Bot

Comment 8 2013-06-21 11:25:09 PDT

Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/921887

kov's GTK+ EWS bot

Comment 9 2013-06-21 11:27:54 PDT

Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/956414