Summary: | WebGL files not included in Windows build (take 2) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, dino, eflews.bot, gtk-ews, gyuyoung.kim, noam, rego+ews, rniwa, webkit-ews, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Alex Christensen
2013-06-20 16:52:30 PDT
Created attachment 205129 [details]
Patch
Comment on attachment 205129 [details] Patch Attachment 205129 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/884381 Comment on attachment 205129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205129&action=review Looks good. I'm going to try building it locally. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:148 > + <ClCompile Include="$(ConfigurationBuildDir)\obj32\WebCore\DerivedSources\JSEXTDrawBuffers.cpp"> I hate how Visual Studio creates all this solution/project file churn. Created attachment 205195 [details]
Patch
Comment on attachment 205195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205195&action=review > Source/WebCore/WebCore.vcxproj/WebCorePreBuild.cmd:7 > +xcopy %WEBKIT_SOURCE%\ThirdParty\ANGLE\include %CONFIGURATIONBUILDDIR%\include /s You should put both path arguments to xcopy in quotes so that the build doesn't break if someone uses a path with spaces in it. Created attachment 205199 [details]
Patch
Created attachment 205202 [details]
Patch
Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/921887 Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/956414 Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/956415 Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/961144 Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/937703 Comment on attachment 205202 [details] Patch Attachment 205202 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/960184 Created attachment 205209 [details]
Patch
Comment on attachment 205209 [details]
Patch
Looks good!
I'm going to wait until the Windows bot turns green, then I'll cq+ it Comment on attachment 205209 [details] Patch Clearing flags on attachment: 205209 Committed r151854: <http://trac.webkit.org/changeset/151854> All reviewed patches have been landed. Closing bug. |