| Summary: | [Qt] Remove Qt specific QTKIT flagged code. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Brüning <michael.bruning> | ||||||||
| Component: | New Bugs | Assignee: | Michael Brüning <michael.bruning> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abecsi, cmarcelo, commit-queue, eric.carlson, glenn, hausmann, jer.noble, menard, pnormand, webkit-ews | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Brüning
2013-06-14 04:01:55 PDT
Created attachment 204699 [details]
Patch
Should the QTKit-related code protected by "USE(GSTREAMER)" elsewhere (eg. WebVideoFullscreenController.mm) also be removed, or it used by other ports? It seems to originate from bug #52280 and appears to be unrelated to this bug. That said, from the Qt side we are not using gstreamer on Mac OS X. It seems that WebVideoFullscreenController.mm is in fact only used by the Mac port, at least telling from the build files. Philippe, are you aware if this is used by any other port? Some years ago I added some GStreamer support to the mac wk1 port but nowadays this is unmaintained. Feel free to remove it. Perhaps one day somebody will step up to add GStreamer support to the mac wk2 port :) Created attachment 204816 [details]
Patch
I overlooked a couple of Qt-specific files that were not used anymore due to this change. The new patch removes those. Eric, I'll file a new bug for the GStreamer code in the Mac port and cc you, I think it's nicer to keep theses things separate in case someone wants to enable GStreamer support on Mac again for some reason... Comment on attachment 204816 [details] Patch Attachment 204816 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/918054 Created attachment 204818 [details]
Patch
Comment on attachment 204818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204818&action=review > Source/WebKit/mac/WebView/WebView.mm:1528 > +#if PLATFORM(MAC) Funny to see #if PLATFORM(QT) in this file :) Committed r151642: <http://trac.webkit.org/changeset/151642> (In reply to comment #7) > I overlooked a couple of Qt-specific files that were not used anymore due to this change. The new patch removes those. > > Eric, I'll file a new bug for the GStreamer code in the Mac port and cc you, I think it's nicer to keep theses things separate in case someone wants to enable GStreamer support on Mac again for some reason... I agree that keeping these separate is a good idea. Thanks for looking into this! |