Bug 117329

Summary:

[CSS Regions] Overflow areas from regions do not redraw

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Radu Stavila <stavila>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abucur, buildbot, commit-queue, mihnea, rniwa, stavila, stearns, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

118665

Bug Blocks:

116295

Attachments:

Description	Flags
Reproduction	none
Patch containing layout & repaint tests	koivisto: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Fixed repaint test failure due to different window sizes	commit-queue: commit-queue-
Added "reviewed by" to CL	none

Dean Jackson

Reported 2013-06-06 18:56:16 PDT

Created attachment 203990 [details] Reproduction It seems like the update rect calculation for regions is incorrect when it has visible overflow. See example.

Attachments
Reproduction (5.15 KB, text/html) 2013-06-06 18:56 PDT, Dean Jackson	no flags	Details
Patch containing layout & repaint tests (10.80 KB, patch) 2013-11-13 09:11 PST, Radu Stavila	koivisto: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (498.16 KB, application/zip) 2013-11-21 07:15 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (539.61 KB, application/zip) 2013-11-21 07:21 PST, Build Bot	no flags	Details
Fixed repaint test failure due to different window sizes (8.74 KB, patch) 2013-11-21 07:38 PST, Radu Stavila	commit-queue: commit-queue-	Details Formatted Diff Diff
Added "reviewed by" to CL (8.74 KB, patch) 2013-11-21 08:22 PST, Radu Stavila	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2013-06-16 23:00:57 PDT

Adobe folks, is there any update on this?

Mihnea Ovidenie

Comment 2 2013-06-16 23:46:40 PDT

Yes, we are working on setting the overflow properly on regions.

Radu Stavila

Comment 3 2013-11-13 09:11:10 PST

Created attachment 216810 [details] Patch containing layout & repaint tests This problem has been fixed by https://bugs.webkit.org/show_bug.cgi?id=118665. After that patch lands, these new tests can be landed as well (the tests fail on the current implementation, without the 118665 patch).

Build Bot

Comment 4 2013-11-21 07:15:46 PST

Comment on attachment 216810 [details] Patch containing layout & repaint tests Attachment 216810 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/31768053 New failing tests: fast/repaint/repaint-regions-overflow.html

Build Bot

Comment 5 2013-11-21 07:15:48 PST

Created attachment 217563 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2013-11-21 07:21:45 PST

Comment on attachment 216810 [details] Patch containing layout & repaint tests Attachment 216810 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/31758051 New failing tests: fast/repaint/repaint-regions-overflow.html

Build Bot

Comment 7 2013-11-21 07:21:47 PST

Created attachment 217565 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Radu Stavila

Comment 8 2013-11-21 07:38:28 PST

Created attachment 217568 [details] Fixed repaint test failure due to different window sizes

WebKit Commit Bot

Comment 9 2013-11-21 08:18:51 PST

Comment on attachment 217568 [details] Fixed repaint test failure due to different window sizes Rejecting attachment 217568 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 217568, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/31518070

Radu Stavila

Comment 10 2013-11-21 08:22:54 PST

Created attachment 217572 [details] Added "reviewed by" to CL

WebKit Commit Bot

Comment 11 2013-11-21 08:48:26 PST

Comment on attachment 217572 [details] Added "reviewed by" to CL Clearing flags on attachment: 217572 Committed r159628: <http://trac.webkit.org/changeset/159628>

Note You need to log in before you can comment on or make changes to this bug.