| Summary: | [CSS Regions] Overflow areas from regions do not redraw | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||||||||
| Component: | CSS | Assignee: | Radu Stavila <stavila> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | abucur, buildbot, commit-queue, mihnea, rniwa, stavila, stearns, WebkitBugTracker | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 118665 | ||||||||||||||||
| Bug Blocks: | 116295 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Adobe folks, is there any update on this? Yes, we are working on setting the overflow properly on regions. Created attachment 216810 [details] Patch containing layout & repaint tests This problem has been fixed by https://bugs.webkit.org/show_bug.cgi?id=118665. After that patch lands, these new tests can be landed as well (the tests fail on the current implementation, without the 118665 patch). Comment on attachment 216810 [details] Patch containing layout & repaint tests Attachment 216810 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/31768053 New failing tests: fast/repaint/repaint-regions-overflow.html Created attachment 217563 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 216810 [details] Patch containing layout & repaint tests Attachment 216810 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/31758051 New failing tests: fast/repaint/repaint-regions-overflow.html Created attachment 217565 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 217568 [details]
Fixed repaint test failure due to different window sizes
Comment on attachment 217568 [details] Fixed repaint test failure due to different window sizes Rejecting attachment 217568 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 217568, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/31518070 Created attachment 217572 [details]
Added "reviewed by" to CL
Comment on attachment 217572 [details] Added "reviewed by" to CL Clearing flags on attachment: 217572 Committed r159628: <http://trac.webkit.org/changeset/159628> |
Created attachment 203990 [details] Reproduction It seems like the update rect calculation for regions is incorrect when it has visible overflow. See example.