Bug 116484
| Summary: | Simplify RenderFlexibleBox::computeMainAxisExtentForChild | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, dino, hyatt, mmaxfield, rreno, simon.fraser, vitor.roriz, zalan |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
We should consider merging https://chromium.googlesource.com/chromium/blink/+/b2181608f7b4697190b880d8a2d7b302a96d031e
Simplify RenderFlexibleBox::computeMainAxisExtentForChild
We only need to check size.isIntrinsic(), not all of
height/min-height/max-height. We can also use layoutIfNeeded().
No new tests - no behavior change.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I don't understand the refactoring done - https://github.com/WebKit/WebKit/blob/62e012dfc64a13172b55d9115d77119ec8dbe794/Source/WebCore/rendering/RenderFlexibleBox.cpp#L653
Appreciate if someone can have a look and see if anything else is needed here or not? Thanks!
Ryan Reno
This was resolved in a mass Blink flexbox import.
https://bugs.webkit.org/show_bug.cgi?id=168657
*** This bug has been marked as a duplicate of bug 168657 ***