Bug 116377

Summary: [GTK] [CMake] Add support for building WebKit1
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115966, 125766, 125767    
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2013-05-17 19:32:52 PDT
Since we need to maintain WebKit1 for some time, it probably makes sense to add support for building it with CMake.
Attachments
Patch (20.94 KB, patch)
2013-12-16 00:21 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-12-16 00:21:40 PST
Created attachment 219299 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-12-18 12:43:14 PST
Comment on attachment 219299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219299&action=review > Source/WebKit/gtk/GNUmakefile.am:362 > + $(AM_V_GEN)glib-mkenums --template $(srcdir)/Source/WebKit/gtk/webkit/webkitenumtypes.h.template $(webkitgtk_h_api) | \ Much nicer =) > ChangeLog:10 > + * Source/cmake/OptionsGTK.cmake: Turn off some features that do not build properly > + for WebKit1 and stop using the version script which we haven't implemented yet. Turn > + on WebKit1. The version script was not actually being used, was it?
Martin Robinson
Comment 3 2013-12-18 15:59:00 PST
(In reply to comment #2) > The version script was not actually being used, was it? Nope. It didn't even exist. :)
Martin Robinson
Comment 4 2013-12-18 16:01:46 PST
Committed r160804: <http://trac.webkit.org/changeset/160804>
Note You need to log in before you can comment on or make changes to this bug.