Bug 116116

Summary: Get rid of [CustomGetter] for global named constructors
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, ggaren, haraken, laszlo.gombos, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115853, 116343    
Attachments:
Description Flags
Patch
none
Patch
ggaren: review+
Patch for landing none

Chris Dumez
Reported 2013-05-14 12:22:08 PDT
The JSC bindings generator should be smart enough to generate code for global named constructors. Currently those require custom code (via [CustomGetter] extended attribute). For e.g. in DOMWindow.idl: [CustomGetter] attribute HTMLOptionElementConstructorConstructor Option; [CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementConstructorConstructor Audio;
Attachments
Patch (10.10 KB, patch)
2013-05-14 13:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.79 KB, patch)
2013-05-15 00:51 PDT, Chris Dumez 		ggaren: review+
DetailsFormatted DiffDiff
Patch for landing (9.45 KB, patch)
2013-05-17 11:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-14 13:04:00 PDT
Created attachment 201746 [details] Patch
Chris Dumez
Comment 2 2013-05-15 00:51:23 PDT
Created attachment 201799 [details] Patch
Chris Dumez
Comment 3 2013-05-15 04:35:45 PDT
The "Audio" global constructor will be automatically generated as well once we support [EnabledAtRuntime] extended attribute for global constructors (Bug 116147).
Chris Dumez
Comment 4 2013-05-17 00:21:57 PDT
Any feedback on this patch?
Kentaro Hara
Comment 5 2013-05-17 00:25:54 PDT
Comment on attachment 201799 [details] Patch Looks correct, but JSC guys should take a look.
Geoffrey Garen
Comment 6 2013-05-17 10:51:17 PDT
Comment on attachment 201799 [details] Patch r=me
Chris Dumez
Comment 7 2013-05-17 11:33:07 PDT
Created attachment 202126 [details] Patch for landing
WebKit Commit Bot
Comment 8 2013-05-17 12:16:34 PDT
Comment on attachment 202126 [details] Patch for landing Clearing flags on attachment: 202126 Committed r150283: <http://trac.webkit.org/changeset/150283>
WebKit Commit Bot
Comment 9 2013-05-17 12:16:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.