Bug 116109

Summary:

[Windows] Switch to embedded manifest commands for launcher executables

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit EFL

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Brent Fulgham 2013-05-14 10:36:01 PDT

I recently added an external manifest file to the Windows build (see Bug 115935).  Instead, it is easier to maintain embedded manifest definitions, especially since most of our tools derive from the same DLLLauncherMain.cpp source file.

This change updates DLLLaunherMain.cpp with a conditional manifest command that instructions VS2010 (or newer) builds to select the specific VS2005 runtime used to build the various WebKitAuxiliaryLibraries and WebKitSupportLibraries components.

Comment 1 Brent Fulgham 2013-05-14 10:38:30 PDT

Created attachment 201732 [details]
Patch

Comment 2 Darin Adler 2013-05-14 10:39:30 PDT

Comment on attachment 201732 [details]
Patch

rs=me

Comment 3 Brent Fulgham 2013-05-14 10:56:39 PDT

Committed r150080: <http://trac.webkit.org/changeset/150080>