Bug 116109

Summary: [Windows] Switch to embedded manifest commands for launcher executables
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit EFLAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Brent Fulgham
Reported 2013-05-14 10:36:01 PDT
I recently added an external manifest file to the Windows build (see Bug 115935). Instead, it is easier to maintain embedded manifest definitions, especially since most of our tools derive from the same DLLLauncherMain.cpp source file. This change updates DLLLaunherMain.cpp with a conditional manifest command that instructions VS2010 (or newer) builds to select the specific VS2005 runtime used to build the various WebKitAuxiliaryLibraries and WebKitSupportLibraries components.
Attachments
Patch (2.87 KB, patch)
2013-05-14 10:38 PDT, Brent Fulgham 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-05-14 10:38:30 PDT
Created attachment 201732 [details] Patch
Darin Adler
Comment 2 2013-05-14 10:39:30 PDT
Comment on attachment 201732 [details] Patch rs=me
Brent Fulgham
Comment 3 2013-05-14 10:56:39 PDT
Committed r150080: <http://trac.webkit.org/changeset/150080>
Note You need to log in before you can comment on or make changes to this bug.