Bug 115977

Summary:

Apply FINAL to the RenderObject hierarchy.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, kling, rniwa, simon.fraser

Priority:

Keywords:

Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

115990, 116369

Bug Blocks:

Attachments:

Description	Flags
Snack for EWS	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Patch without devirtualization tweaks	none
Patch again, now that bots are updated!	commit-queue: commit-queue-

Andreas Kling

Reported 2013-05-11 19:45:25 PDT

Merge Blink r148795: https://chromium.googlesource.com/chromium/blink/+/8817a9cad327010d1c2fd254810218ec0eda9fe4

Attachments
Snack for EWS (109.48 KB, patch) 2013-05-12 05:29 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (123.48 KB, patch) 2013-05-12 06:26 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (726.92 KB, application/zip) 2013-05-13 22:18 PDT, Build Bot	no flags	Details
Patch without devirtualization tweaks (119.93 KB, patch) 2013-05-17 11:54 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch again, now that bots are updated! (122.98 KB, patch) 2013-07-25 20:09 PDT, Andreas Kling	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-05-12 05:29:50 PDT

Created attachment 201485 [details] Snack for EWS

WebKit Commit Bot

Comment 2 2013-05-12 05:30:59 PDT

Attachment 201485 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1 Source/WebCore/rendering/RenderText.h:104: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 97 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2013-05-12 06:26:32 PDT

Created attachment 201486 [details] Patch

WebKit Commit Bot

Comment 4 2013-05-12 06:29:13 PDT

Attachment 201486 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1 Source/WebCore/rendering/RenderText.h:104: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 101 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 5 2013-05-12 06:38:03 PDT

Committed r149955: <http://trac.webkit.org/changeset/149955>

Simon Fraser (smfr)

Comment 6 2013-05-12 10:58:53 PDT

This may have caused ~20 new test failures: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r149955%20(9763)/results.html

WebKit Commit Bot

Comment 7 2013-05-12 11:04:04 PDT

Re-opened since this is blocked by bug 115990

Build Bot

Comment 8 2013-05-13 22:18:54 PDT

Comment on attachment 201486 [details] Patch Attachment 201486 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/473030 New failing tests: editing/selection/4895428-2.html svg/hittest/svg-padding.xhtml svg/hittest/svg-inside-table.xhtml fast/repaint/table-hover-on-link.html fast/table/hittest-tablecell-with-borders-right-edge.html tables/hittesting/filltable-outline.html fast/events/iframe-onmousemove.html fast/dom/nodesFromRect/nodesFromRect-table.html fast/forms/select/listbox-in-multi-column.html tables/hittesting/filltable-emptycells.html tables/hittesting/filltable-levels.html tables/hittesting/filltable-stress.html fast/writing-mode/table-hit-test.html fast/css/nested-layers-with-hover.html svg/hittest/svg-inside-display-table.xhtml tables/hittesting/filltable-rtl.html fast/forms/range/slider-in-multi-column.html fast/table/hittest-tablecell-bottom-edge.html fast/events/fire-mousedown-while-pressing-mouse-button.html fast/table/hittest-tablecell-with-borders-bottom-edge.html fast/table/hittest-tablecell-right-edge.html

Build Bot

Comment 9 2013-05-13 22:18:56 PDT

Created attachment 201678 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Andreas Kling

Comment 10 2013-05-17 11:54:10 PDT

Created attachment 202131 [details] Patch without devirtualization tweaks

Andreas Kling

Comment 11 2013-05-17 13:32:21 PDT

Committed r150294: <http://trac.webkit.org/changeset/150294>

WebKit Commit Bot

Comment 12 2013-05-17 17:47:42 PDT

Re-opened since this is blocked by bug 116369

Andreas Kling

Comment 13 2013-05-17 21:32:11 PDT

This keeps breaking on the bots because they are running a buggy old version of Xcode. We'll need to update it.

Andreas Kling

Comment 14 2013-07-25 20:09:02 PDT

Created attachment 207503 [details] Patch again, now that bots are updated!

WebKit Commit Bot

Comment 15 2013-07-25 20:24:33 PDT

Attachment 207503 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1 Source/WebCore/rendering/RenderText.h:104: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 101 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 16 2013-07-26 08:50:29 PDT

Can you mail webkit-dev explaining FINAL (and reminding on OVERRIDE) once this lands?

Andreas Kling

Comment 17 2013-07-26 09:03:47 PDT

(In reply to comment #16) > Can you mail webkit-dev explaining FINAL (and reminding on OVERRIDE) once this lands? Will do.

WebKit Commit Bot

Comment 18 2013-07-26 13:34:54 PDT

Comment on attachment 207503 [details] Patch again, now that bots are updated! Rejecting attachment 207503 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 207503, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1250312

Andreas Kling

Comment 19 2013-07-26 13:40:50 PDT

Committed r153380: <http://trac.webkit.org/changeset/153380>

Note You need to log in before you can comment on or make changes to this bug.