Bug 115678

Summary: KeyframeValueList::m_values should be Vector of OwnPtrs
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, darin, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, philn, simon.fraser, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73757    
Attachments:
Description Flags
Patch simon.fraser: review-, eflews.bot: commit-queue-

Anders Carlsson
Reported 2013-05-06 14:33:18 PDT
KeyframeValueList::m_values should be Vector of OwnPtrs
Attachments
Patch (35.63 KB, patch)
2013-05-06 14:55 PDT, Anders Carlsson 		simon.fraser: review-
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-06 14:55:55 PDT
Created attachment 200817 [details] Patch
EFL EWS Bot
Comment 2 2013-05-06 15:00:17 PDT
Comment on attachment 200817 [details] Patch Attachment 200817 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/378270
Early Warning System Bot
Comment 3 2013-05-06 15:01:30 PDT
Comment on attachment 200817 [details] Patch Attachment 200817 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/281201
Simon Fraser (smfr)
Comment 4 2013-05-06 15:40:27 PDT
Comment on attachment 200817 [details] Patch r-. Lots of red EWS and no justification.
Darin Adler
Comment 5 2013-05-07 09:13:04 PDT
I fixed this in bug 115652, but Anders’ patch has some additional refactoring that still might be worthwhile beyond my fix. *** This bug has been marked as a duplicate of bug 115652 ***
Anders Carlsson
Comment 6 2013-05-07 10:55:16 PDT
(In reply to comment #5) > I fixed this in bug 115652, but Anders’ patch has some additional refactoring that still might be worthwhile beyond my fix. > > *** This bug has been marked as a duplicate of bug 115652 *** Doing the additional refactoring in https://bugs.webkit.org/show_bug.cgi?id=115738.
Note You need to log in before you can comment on or make changes to this bug.