Bug 115738 - Clean up KeyframeValueList and related classes
Summary: Clean up KeyframeValueList and related classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-07 10:49 PDT by Anders Carlsson
Modified: 2013-05-07 15:03 PDT (History)
16 users (show)

See Also:

Attachments
Patch (37.46 KB, patch)
2013-05-07 10:53 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (41.84 KB, patch)
2013-05-07 11:02 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (44.10 KB, patch)
2013-05-07 11:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (45.87 KB, patch)
2013-05-07 11:26 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (46.79 KB, patch)
2013-05-07 12:08 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (47.15 KB, patch)
2013-05-07 12:18 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (48.21 KB, patch)
2013-05-07 12:36 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (48.20 KB, patch)
2013-05-07 12:44 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (49.31 KB, patch)
2013-05-07 13:33 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (49.80 KB, patch)
2013-05-07 14:24 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch for landing (49.43 KB, patch)
2013-05-07 14:36 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-07 10:49:21 PDT 
Clean up KeyframeValueList and related classes
Comment 1 Anders Carlsson 2013-05-07 10:53:43 PDT 
Created attachment 200929 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-07 10:58:34 PDT 
Comment on attachment 200929 [details]
Patch

Attachment 200929 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/347183
Comment 3 Early Warning System Bot 2013-05-07 11:00:13 PDT 
Comment on attachment 200929 [details]
Patch

Attachment 200929 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/356096
Comment 4 EFL EWS Bot 2013-05-07 11:00:36 PDT 
Comment on attachment 200929 [details]
Patch

Attachment 200929 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/356097
Comment 5 Anders Carlsson 2013-05-07 11:02:09 PDT 
Created attachment 200935 [details]
Patch
Comment 6 Early Warning System Bot 2013-05-07 11:13:28 PDT 
Comment on attachment 200935 [details]
Patch

Attachment 200935 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/323089
Comment 7 Anders Carlsson 2013-05-07 11:17:13 PDT 
Created attachment 200939 [details]
Patch
Comment 8 EFL EWS Bot 2013-05-07 11:22:05 PDT 
Comment on attachment 200939 [details]
Patch

Attachment 200939 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/356107
Comment 9 Early Warning System Bot 2013-05-07 11:23:32 PDT 
Comment on attachment 200939 [details]
Patch

Attachment 200939 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/271127
Comment 10 Early Warning System Bot 2013-05-07 11:25:01 PDT 
Comment on attachment 200939 [details]
Patch

Attachment 200939 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/355139
Comment 11 Anders Carlsson 2013-05-07 11:26:47 PDT 
Created attachment 200945 [details]
Patch
Comment 12 Early Warning System Bot 2013-05-07 11:37:56 PDT 
Comment on attachment 200945 [details]
Patch

Attachment 200945 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/338137
Comment 13 EFL EWS Bot 2013-05-07 11:41:10 PDT 
Comment on attachment 200945 [details]
Patch

Attachment 200945 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/336168
Comment 14 Early Warning System Bot 2013-05-07 11:42:50 PDT 
Comment on attachment 200945 [details]
Patch

Attachment 200945 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/359135
Comment 15 EFL EWS Bot 2013-05-07 11:49:19 PDT 
Comment on attachment 200945 [details]
Patch

Attachment 200945 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/359139
Comment 16 Anders Carlsson 2013-05-07 12:08:32 PDT 
Created attachment 200954 [details]
Patch
Comment 17 Early Warning System Bot 2013-05-07 12:13:14 PDT 
Comment on attachment 200954 [details]
Patch

Attachment 200954 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/355154
Comment 18 EFL EWS Bot 2013-05-07 12:13:24 PDT 
Comment on attachment 200954 [details]
Patch

Attachment 200954 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/347213
Comment 19 Early Warning System Bot 2013-05-07 12:14:12 PDT 
Comment on attachment 200954 [details]
Patch

Attachment 200954 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/347211
Comment 20 Anders Carlsson 2013-05-07 12:18:24 PDT 
Created attachment 200956 [details]
Patch
Comment 21 Early Warning System Bot 2013-05-07 12:24:51 PDT 
Comment on attachment 200956 [details]
Patch

Attachment 200956 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/271150
Comment 22 Early Warning System Bot 2013-05-07 12:25:36 PDT 
Comment on attachment 200956 [details]
Patch

Attachment 200956 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/355159
Comment 23 EFL EWS Bot 2013-05-07 12:26:40 PDT 
Comment on attachment 200956 [details]
Patch

Attachment 200956 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/442097
Comment 24 Anders Carlsson 2013-05-07 12:36:33 PDT 
Created attachment 200958 [details]
Patch
Comment 25 EFL EWS Bot 2013-05-07 12:42:35 PDT 
Comment on attachment 200958 [details]
Patch

Attachment 200958 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/336191
Comment 26 Anders Carlsson 2013-05-07 12:44:39 PDT 
Created attachment 200960 [details]
Patch
Comment 27 Early Warning System Bot 2013-05-07 12:59:33 PDT 
Comment on attachment 200960 [details]
Patch

Attachment 200960 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/323133
Comment 28 Simon Fraser (smfr) 2013-05-07 13:04:48 PDT 
Comment on attachment 200960 [details]
Patch

r=me for this and any future version of this patch.
Comment 29 Anders Carlsson 2013-05-07 13:33:38 PDT 
Created attachment 200964 [details]
Patch
Comment 30 Noam Rosenthal 2013-05-07 13:36:26 PDT 
Next time let me know and I'll do the coordinated graphics related part... takes me a minute when I can compile it :)
Comment 31 Early Warning System Bot 2013-05-07 13:39:29 PDT 
Comment on attachment 200964 [details]
Patch

Attachment 200964 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/266162
Comment 32 Noam Rosenthal 2013-05-07 14:24:26 PDT 
Created attachment 200977 [details]
Patch
Comment 33 Noam Rosenthal 2013-05-07 14:36:33 PDT 
Created attachment 200978 [details]
Patch for landing
Comment 34 WebKit Commit Bot 2013-05-07 15:03:15 PDT 
Comment on attachment 200978 [details]
Patch for landing

Clearing flags on attachment: 200978

Committed r149694: <http://trac.webkit.org/changeset/149694>
Comment 35 WebKit Commit Bot 2013-05-07 15:03:21 PDT 
All reviewed patches have been landed.  Closing bug.