Bug 115626

Summary: JSC ARM traditional failing on Octane NavierStokes test
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ossy, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
proposed fix none

Gabor Rapcsanyi
Reported 2013-05-06 01:43:57 PDT
JSC ARM traditional failing on Octane NavierStokes test
Attachments
proposed fix (1.34 KB, patch)
2013-05-06 04:10 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2013-05-06 04:10:50 PDT
Created attachment 200653 [details] proposed fix
WebKit Commit Bot
Comment 2 2013-05-06 04:13:04 PDT
Attachment 200653 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/ARMAssembler.h']" exit_code: 1 Source/JavaScriptCore/assembler/ARMAssembler.h:166: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/JavaScriptCore/assembler/ARMAssembler.h:167: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zoltan Herczeg
Comment 3 2013-05-06 08:55:56 PDT
Comment on attachment 200653 [details] proposed fix r=me
WebKit Commit Bot
Comment 4 2013-05-06 09:36:52 PDT
Comment on attachment 200653 [details] proposed fix Clearing flags on attachment: 200653 Committed r149601: <http://trac.webkit.org/changeset/149601>
WebKit Commit Bot
Comment 5 2013-05-06 09:36:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.