Bug 115235

Summary: [Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, haraken, ossy, szledan, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110573    
Bug Blocks: 79666    
Attachments:
Description Flags
Patch none

Description Ádám Kallai 2013-04-26 01:32:04 PDT
* fast/dom/DeviceMotion/window-property.html
diff:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-actual.txt
@@ -5,7 +5,7 @@
 
 PASS typeof window.DeviceMotionEvent == 'object' is true
 PASS typeof window.DeviceMotionEvent == 'function' is false
-PASS hasDeviceMotionEventProperty() is true
+FAIL hasDeviceMotionEventProperty() should be true. Was false.
 PASS 'DeviceMotionEvent' in window is true
 PASS window.hasOwnProperty('DeviceMotionEvent') is true
 PASS typeof window.ondevicemotion == 'object' is true

 * fast/dom/DeviceOrientation/window-property.html
diff:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-actual.txt
@@ -5,7 +5,7 @@
 
 PASS typeof window.DeviceOrientationEvent == 'object' is true
 PASS typeof window.DeviceOrientationEvent == 'function' is false
-PASS hasDeviceOrientationEventProperty() is true
+FAIL hasDeviceOrientationEventProperty() should be true. Was false.
 PASS 'DeviceOrientationEvent' in window is true
 PASS window.hasOwnProperty('DeviceOrientationEvent') is true
 PASS typeof window.ondeviceorientation == 'object' is true
Comment 1 Ádám Kallai 2013-04-26 01:33:02 PDT
Could you check what happened to it, please?
Comment 2 Chris Dumez 2013-04-26 01:34:08 PDT
I'm on it.
Comment 3 Chris Dumez 2013-04-26 01:44:41 PDT
Created attachment 199802 [details]
Patch

Sorry about that, those tests are skipped on EFL so I did not notice the failure.
Comment 4 Kentaro Hara 2013-04-26 01:48:10 PDT
Comment on attachment 199802 [details]
Patch

Thanks for the quick fix!
Comment 5 WebKit Commit Bot 2013-04-26 02:15:29 PDT
Comment on attachment 199802 [details]
Patch

Clearing flags on attachment: 199802

Committed r149171: <http://trac.webkit.org/changeset/149171>
Comment 6 WebKit Commit Bot 2013-04-26 02:15:32 PDT
All reviewed patches have been landed.  Closing bug.