Bug 115135

Summary:

WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

New Bugs

Assignee:

Noam Rosenthal <noam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, benjamin, esprehn+autocc, glenn, nick.diego, noam, rafael.lobo, sergio, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
GDB Stack trace	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

WebKit Commit Bot

Reported 2013-04-24 15:48:40 PDT

[Qt][WK2] WebProcess is crashing on http://achicu.github.io/css-presentation Requested by rafaelbrandao on #webkit.

Attachments
GDB Stack trace (9.41 KB, application/octet-stream) 2013-04-25 10:40 PDT, Sergio Correia (qrwteyrutiyoup)	no flags	Details
Patch (5.81 KB, patch) 2013-05-09 15:09 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch (13.97 KB, patch) 2013-05-09 15:15 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch (5.86 KB, patch) 2013-05-09 15:43 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (4.20 KB, patch) 2013-05-24 09:05 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (5.68 KB, patch) 2013-05-24 09:06 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Sergio Correia (qrwteyrutiyoup)

Comment 1 2013-04-25 10:40:20 PDT

This regression seems to be caused by https://bugs.webkit.org/show_bug.cgi?id=109588, or at least git bisect thinks so :)

Sergio Correia (qrwteyrutiyoup)

Comment 2 2013-04-25 10:40:51 PDT

Created attachment 199685 [details] GDB Stack trace

Noam Rosenthal

Comment 3 2013-05-09 15:09:37 PDT

Created attachment 201285 [details] Patch

Noam Rosenthal

Comment 4 2013-05-09 15:15:58 PDT

Created attachment 201287 [details] Patch

Benjamin Poulain

Comment 5 2013-05-09 15:37:40 PDT

This is only common code. Why is this marked [Qt][EFL]?

Noam Rosenthal

Comment 6 2013-05-09 15:40:36 PDT

(In reply to comment #5) > This is only common code. Why is this marked [Qt][EFL]? I think when the bug was reported it wasn't clear that the problem was in common code, since that common code is currently activated only in coordinated graphics.

Noam Rosenthal

Comment 7 2013-05-09 15:43:57 PDT

Created attachment 201294 [details] Patch

Antti Koivisto

Comment 8 2013-05-24 08:37:24 PDT

Comment on attachment 201294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201294&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1477 > + CachedImage* cachedImage = style->backgroundLayers()->image()->cachedImage(); > + ASSERT(cachedImage); > + > + RefPtr<Image> image = cachedImage->image(); This assertion seems unnecessary. Calling without null checking already communicates that the pointer is expected not to be null and we are going to get a clean crash anyway if it not.

Noam Rosenthal

Comment 9 2013-05-24 09:05:16 PDT

Created attachment 202825 [details] Patch for landing

Noam Rosenthal

Comment 10 2013-05-24 09:06:20 PDT

Created attachment 202826 [details] Patch for landing

WebKit Commit Bot

Comment 11 2013-05-24 09:34:28 PDT

Comment on attachment 202826 [details] Patch for landing Clearing flags on attachment: 202826 Committed r150643: <http://trac.webkit.org/changeset/150643>

WebKit Commit Bot

Comment 12 2013-05-24 09:34:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.