Bug 115053

Summary: [Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 114526    
Bug Blocks:    
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Zoltan Horvath
Reported 2013-04-23 13:15:53 PDT
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/59581/steps/layout-test/logs/stdio Regressions: Unexpected image-only failures (2) fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html [ ImageOnlyFailure ] fast/exclusions/shape-inside/shape-inside-percentage.html [ ImageOnlyFailure ]
Attachments
proposed patch (3.56 KB, patch)
2013-05-07 16:43 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (3.56 KB, patch)
2013-05-07 16:51 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (8.46 KB, patch)
2013-05-08 14:22 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-05-07 16:43:18 PDT
Created attachment 200994 [details] proposed patch By modifying the test-expected the error gets fixed.
Zoltan Horvath
Comment 2 2013-05-07 16:51:46 PDT
Created attachment 200995 [details] proposed patch
Zoltan Horvath
Comment 3 2013-05-07 16:56:06 PDT
Comment on attachment 200995 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=200995&action=review > LayoutTests/platform/qt/TestExpectations:1511 > fast/exclusions/shape-inside/shape-inside-polygon-layout.html Please note that this test has been skipped and put under this bug in: http://trac.webkit.org/changeset/149484 but it has nothing to do with this bug.
Zoltan Horvath
Comment 4 2013-05-08 14:22:34 PDT
Created attachment 201108 [details] proposed patch Tested on Qt{Mac,Linux} Safari{Mac}
Alexandru Chiculita
Comment 5 2013-05-09 16:40:48 PDT
Comment on attachment 201108 [details] proposed patch Thanks Zoltan! Looks good.
WebKit Commit Bot
Comment 6 2013-05-09 17:11:42 PDT
Comment on attachment 201108 [details] proposed patch Clearing flags on attachment: 201108 Committed r149857: <http://trac.webkit.org/changeset/149857>
WebKit Commit Bot
Comment 7 2013-05-09 17:11:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.