Bug 115053 - [Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
Summary: [Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on: 114526
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-23 13:15 PDT by Zoltan Horvath
Modified: 2013-05-09 17:11 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (3.56 KB, patch)
2013-05-07 16:43 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
proposed patch (3.56 KB, patch)
2013-05-07 16:51 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
proposed patch (8.46 KB, patch)
2013-05-08 14:22 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-04-23 13:15:53 PDT 
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/59581/steps/layout-test/logs/stdio

Regressions: Unexpected image-only failures (2)
  fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html [ ImageOnlyFailure ]
  fast/exclusions/shape-inside/shape-inside-percentage.html [ ImageOnlyFailure ]
Comment 1 Zoltan Horvath 2013-05-07 16:43:18 PDT 
Created attachment 200994 [details]
proposed patch

By modifying the test-expected the error gets fixed.
Comment 2 Zoltan Horvath 2013-05-07 16:51:46 PDT 
Created attachment 200995 [details]
proposed patch
Comment 3 Zoltan Horvath 2013-05-07 16:56:06 PDT 
Comment on attachment 200995 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200995&action=review

> LayoutTests/platform/qt/TestExpectations:1511
>  fast/exclusions/shape-inside/shape-inside-polygon-layout.html

Please note that this test has been skipped and put under this bug in: http://trac.webkit.org/changeset/149484 but it has nothing to do with this bug.
Comment 4 Zoltan Horvath 2013-05-08 14:22:34 PDT 
Created attachment 201108 [details]
proposed patch

Tested on Qt{Mac,Linux} Safari{Mac}
Comment 5 Alexandru Chiculita 2013-05-09 16:40:48 PDT 
Comment on attachment 201108 [details]
proposed patch

Thanks Zoltan! Looks good.
Comment 6 WebKit Commit Bot 2013-05-09 17:11:42 PDT 
Comment on attachment 201108 [details]
proposed patch

Clearing flags on attachment: 201108

Committed r149857: <http://trac.webkit.org/changeset/149857>
Comment 7 WebKit Commit Bot 2013-05-09 17:11:44 PDT 
All reviewed patches have been landed.  Closing bug.