Bug 114612

Summary:

REGRESSION(r148378): editing/style/block-style-005.html failing

Product:

WebKit

Reporter:

Zoltan Arvai <zarvai>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, kadam, l.bialek, rniwa, sergio, sukolsak

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79666, 110979

Attachments:

Description	Flags
Patch	none

Description Zoltan Arvai 2013-04-15 02:30:53 PDT

After r148378 editing/style/block-style-005.html failing on Qt and GTK:

--- /ramdisk/qt-linux-release/build/layout-test-results/editing/style/block-style-005-expected.txt
+++ /ramdisk/qt-linux-release/build/layout-test-results/editing/style/block-style-005-actual.txt
@@ -1,9 +1,8 @@
 You should see one "x" followed by two blank lines. The blank lines should be the same height. The second line must be the same height as the first. See: <rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines
 x
-
-
+x
 execInsertParagraphCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div>
 execInsertParagraphCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div><div id="test" class="editing"><br></div>
 execTypeCharacterCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div><div id="test" class="editing">x</div>
 execFontSizeCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><font size="7"><br></font></div><div id="test" class="editing"><font size="7">x</font></div>
-execDeleteCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><font size="7"><br></font></div><div id="test" class="editing"><br></div>
+execDeleteCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><span style="font-size: -webkit-xxx-large;">x</span></div>

Comment 1 Zoltan Arvai 2013-04-15 07:18:01 PDT

Test skipped on Qt in http://trac.webkit.org/changeset/148436.
Please unksip it with proper fix.

Comment 2 Lukasz Bialek 2014-02-06 07:10:35 PST

*** Bug 128245 has been marked as a duplicate of this bug. ***

Comment 3 Alexey Proskuryakov 2014-02-06 09:31:22 PST

This test is still failing on Gtk and Efl, and it's skipped on Windows via bug 116564. Appears to pass on Mac.

Comment 4 Lukasz Bialek 2014-02-06 23:47:20 PST

Created attachment 223430 [details]
Patch

This patch fixes the test on EFL and GTK ports.

Comment 5 WebKit Commit Bot 2014-02-07 02:47:14 PST

Comment on attachment 223430 [details]
Patch

Clearing flags on attachment: 223430

Committed r163620: <http://trac.webkit.org/changeset/163620>

Comment 6 WebKit Commit Bot 2014-02-07 02:47:18 PST

All reviewed patches have been landed.  Closing bug.