Summary: | Isolate Early Warning System definitions into a JSON | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alancutter, benjamin, commit-queue, dpranke, gyuyoung.kim, ossy, pnormand | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=159990 | ||||||
Bug Depends on: | 114669, 114737 | ||||||
Bug Blocks: | 114564 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-04-13 03:13:29 PDT
Created attachment 197930 [details]
Adds ews.json
Comment on attachment 197930 [details] Adds ews.json View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review > Tools/ChangeLog:3 > + Isolate Early Warning System defintions into a JSON Typo: defintions > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:155 > + 'run_tests': config.get('runTests', False), cls.run_tests? I'm glad to see this change to the EWS, any plans for the QueueStatusServer to use the same data? Committed r148498: <http://trac.webkit.org/changeset/148498> Re-opened since this is blocked by bug 114669 Committed r148588: <http://trac.webkit.org/changeset/148588> Comment on attachment 197930 [details] Adds ews.json View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:152 > + 'name': config['port'] + '-ews', This change killed the Qt WK2 EWS, because the port is qt, but its name should be qt-wk2-ews. Fix is coming soon in https://bugs.webkit.org/show_bug.cgi?id=114737 |