Bug 114455

Summary: [CSS Shaders] Parse the parameters descriptor
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, macpherson, menard, rniwa, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113695    
Attachments:
Description Flags
Patch for parameters.
none
Patch for parameters.
dino: review+
Patch for landing. none

Description Dirk Schulze 2013-04-11 11:59:36 PDT
Parse the parameters descriptor of the filter at-rule.
Comment 1 Michelangelo De Simone 2013-04-11 12:01:38 PDT

*** This bug has been marked as a duplicate of bug 113565 ***
Comment 2 Dirk Schulze 2013-04-11 12:24:44 PDT
Created attachment 197651 [details]
Patch for parameters.
Comment 3 Dirk Schulze 2013-04-11 12:26:41 PDT
The other bug is a dup.
Comment 4 Dirk Schulze 2013-04-11 12:28:22 PDT
Created attachment 197652 [details]
Patch for parameters.
Comment 5 Dirk Schulze 2013-04-11 12:29:06 PDT
*** Bug 113565 has been marked as a duplicate of this bug. ***
Comment 6 Michelangelo De Simone 2013-04-11 12:32:03 PDT
(In reply to comment #3)

> The other bug is a dup.

I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion.
Comment 7 Dirk Schulze 2013-04-11 12:34:34 PDT
(In reply to comment #6)
> (In reply to comment #3)
> 
> > The other bug is a dup.
> 
> I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion.

And I am sure you know that I don't care.
Comment 8 Dean Jackson 2013-04-11 12:34:40 PDT
Comment on attachment 197652 [details]
Patch for parameters. 

View in context: https://bugs.webkit.org/attachment.cgi?id=197652&action=review

> Source/WebCore/ChangeLog:9
> +        parametrization of CSS Shaders.

typo: parameterization (although I'm not sure it is a real word anyway :)
Comment 9 Dirk Schulze 2013-04-11 12:40:40 PDT
Created attachment 197655 [details]
Patch for landing.
Comment 10 WebKit Commit Bot 2013-04-11 13:03:49 PDT
Comment on attachment 197655 [details]
Patch for landing.

Clearing flags on attachment: 197655

Committed r148227: <http://trac.webkit.org/changeset/148227>
Comment 11 WebKit Commit Bot 2013-04-11 13:03:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Ryosuke Niwa 2013-04-11 17:44:26 PDT
It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm
Comment 13 Ryosuke Niwa 2013-04-11 17:48:22 PDT
(In reply to comment #12)
> It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?
> 
> http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm

(In reply to comment #12)
> It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?
> 
> http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm

I guess not. It's probably caused by the slave reboot. Sorry for the noise.