Bug 114418

Summary:

[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.

Product:

WebKit

Reporter:

Glenn Adams <glenn>

Component:

Tools / Tests

Assignee:

Glenn Adams <glenn>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, dpranke, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

114410

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Glenn Adams 2013-04-11 00:42:07 PDT

Complete removal of SCM.add() optional return_exit_code from scm_mock and rebaselineserver. Change rebaselineserver to catch ScriptError in order to determine failure and exit_code.

Comment 1 Glenn Adams 2013-04-11 00:47:15 PDT

Created attachment 197516 [details]
Patch

Comment 2 Ryosuke Niwa 2013-04-11 00:48:39 PDT

Comment on attachment 197516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197516&action=review

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:121
> +        except ScriptError, e:

Please don't use one-letter variable name like e. Spell out error.

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:157
> +        except ScriptError, e:

Ditto.

Comment 3 Glenn Adams 2013-04-11 00:55:05 PDT

Created attachment 197518 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2013-04-11 01:25:41 PDT

Comment on attachment 197518 [details]
Patch for landing

Clearing flags on attachment: 197518

Committed r148183: <http://trac.webkit.org/changeset/148183>

Comment 5 WebKit Commit Bot 2013-04-11 01:25:43 PDT

All reviewed patches have been landed.  Closing bug.