Bug 114410

Summary:

[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}

Product:

WebKit

Reporter:

Glenn Adams <glenn>

Component:

Tools / Tests

Assignee:

Glenn Adams <glenn>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dpranke, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114386, 114418

Attachments:

Description	Flags
Patch	none

Description Glenn Adams 2013-04-10 22:25:26 PDT

No caller of SCM.add or SCM.add_list (or its overrides in SVN/GIT) make use of their return value or specify True for return_exit_code. Simplify these methods by removing the return_exit_code argument and return values.

Comment 1 Glenn Adams 2013-04-10 22:30:03 PDT

Created attachment 197506 [details]
Patch

Comment 2 WebKit Commit Bot 2013-04-10 23:03:03 PDT

Comment on attachment 197506 [details]
Patch

Clearing flags on attachment: 197506

Committed r148173: <http://trac.webkit.org/changeset/148173>

Comment 3 WebKit Commit Bot 2013-04-10 23:03:05 PDT

All reviewed patches have been landed.  Closing bug.