Bug 114410

Summary: [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
Product: WebKit Reporter: Glenn Adams <glenn>
Component: Tools / TestsAssignee: Glenn Adams <glenn>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114386, 114418    
Attachments:
Description Flags
Patch none

Glenn Adams
Reported 2013-04-10 22:25:26 PDT
No caller of SCM.add or SCM.add_list (or its overrides in SVN/GIT) make use of their return value or specify True for return_exit_code. Simplify these methods by removing the return_exit_code argument and return values.
Attachments
Patch (3.32 KB, patch)
2013-04-10 22:30 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Glenn Adams
Comment 1 2013-04-10 22:30:03 PDT
Created attachment 197506 [details] Patch
WebKit Commit Bot
Comment 2 2013-04-10 23:03:03 PDT
Comment on attachment 197506 [details] Patch Clearing flags on attachment: 197506 Committed r148173: <http://trac.webkit.org/changeset/148173>
WebKit Commit Bot
Comment 3 2013-04-10 23:03:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.