Bug 114126

Summary:

Remove WebCore::(enable|disable)SecureTextInput methods

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

WebCore Misc.

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

esprehn+autocc, mifenton, ojan.autocc, rniwa, tkent, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

114081

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Zan Dobersek

Reported 2013-04-07 12:00:31 PDT

The WebCore::enableSecureTextInput and WebCore::disableSecureTextInput methods are/were Chromium-specific and should as such now be removed.

Attachments
Patch (10.10 KB, patch) 2013-04-08 06:46 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (10.74 KB, patch) 2013-04-08 07:15 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (15.40 KB, patch) 2013-04-08 07:35 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2013-04-08 06:46:48 PDT

Created attachment 196851 [details] Patch

Kent Tamura

Comment 2 2013-04-08 07:05:23 PDT

Comment on attachment 196851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196851&action=review > Source/WebCore/html/PasswordInputType.cpp:105 > void PasswordInputType::handleFocusEvent(Node* oldFocusedNode, FocusDirection direction) > { > BaseTextInputType::handleFocusEvent(oldFocusedNode, direction); > - if (element()->document()->frame()) > - element()->document()->setUseSecureKeyboardEntryWhenActive(true); > } > > void PasswordInputType::handleBlurEvent() > { > - if (element()->document()->frame()) > - element()->document()->setUseSecureKeyboardEntryWhenActive(false); > BaseTextInputType::handleBlurEvent(); You should remove PasswordInputType::handleFocusEvent and handleBlurEvent entirely.

Zan Dobersek

Comment 3 2013-04-08 07:15:55 PDT

Created attachment 196853 [details] Patch Thanks for the review, here's the updated patch.

Early Warning System Bot

Comment 4 2013-04-08 07:25:33 PDT

Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17492025

Early Warning System Bot

Comment 5 2013-04-08 07:27:19 PDT

Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17449071

EFL EWS Bot

Comment 6 2013-04-08 07:31:54 PDT

Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17536023