Bug 113945

Summary: [Cairo] Stop passing raw pointers to BitmapImage::create()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, d-r, gns, kenneth, laszlo.gombos, menard, mrobinson, pnormand, rego+ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113929    
Bug Blocks:    
Attachments:
Description Flags
Patch
mrobinson: review+, cdumez: commit-queue-
Patch for landing none

Description Chris Dumez 2013-04-04 11:56:56 PDT
BitmapImage::create() now takes a PassRefPtr<cairo_surface_t> in argument instead of a cairo_surface_t*. Several call sites have not been updated because they were compiling and I missed them. We should stop silently converting cairo_surface_t* to PassRefPtr<cairo_surface_t> when calling BitmapImage::create().
Comment 1 Chris Dumez 2013-04-04 12:06:38 PDT
Created attachment 196501 [details]
Patch
Comment 2 Chris Dumez 2013-04-04 13:36:31 PDT
Comment on attachment 196501 [details]
Patch

GTK build error. I'll investigate.
Comment 3 Chris Dumez 2013-04-04 13:43:53 PDT
Created attachment 196517 [details]
Patch for landing

minor fix for GTK build.
Comment 4 Chris Dumez 2013-04-04 16:57:48 PDT
Committed r147683: <http://trac.webkit.org/changeset/147683>