Bug 113929

Summary: [Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, dino, d-r, fmalita, gustavo, gyuyoung.kim, kenneth, laszlo.gombos, luiz, mrobinson, noam, pdr, rakuco, schenney, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113420    
Bug Blocks: 113945    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-04-04 02:14:24 PDT
NativeImageCairo only holds a RefPtr<cairo_surface_t> member. We could get rid of this unnecessary abstraction and have NativeImagePtr be typedef to RefPtr<cairo_surface_t>.
Attachments
Patch (83.50 KB, patch)
2013-04-04 07:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-04-04 02:30:22 PDT
svg/canvas/canvas-pattern-svg.html added in Bug 113420 is failing for Cairo due to SVGImage::nativeImageForCurrentFrame() implementation being disabled for Cairo.
Chris Dumez
Comment 2 2013-04-04 07:02:12 PDT
Created attachment 196475 [details] Patch
WebKit Review Bot
Comment 3 2013-04-04 07:04:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 4 2013-04-04 10:58:05 PDT
Comment on attachment 196475 [details] Patch Clearing flags on attachment: 196475 Committed r147643: <http://trac.webkit.org/changeset/147643>
WebKit Review Bot
Comment 5 2013-04-04 10:58:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.