Bug 113921

Summary:

fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112840

Attachments:

Description	Flags
the patch	oliver: review+

Description Filip Pizlo 2013-04-03 21:51:31 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2013-04-03 21:54:27 PDT

Created attachment 196435 [details]
the patch

Comment 2 Geoffrey Garen 2013-04-03 22:05:02 PDT

Comment on attachment 196435 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196435&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLLVMHeaders.h:36
> +//   headers don't compile clean with our warnings.

Grammar: "cleanly".

Comment 3 Filip Pizlo 2013-04-03 22:08:52 PDT

Landed in http://trac.webkit.org/changeset/147608