Bug 113921 - fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
Summary: fourthTier: Include LLVM headers with surrounding #pragmas instead of using m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-04-03 21:51 PDT by Filip Pizlo
Modified: 2013-04-03 22:08 PDT (History)
7 users (show)

See Also:

Attachments
the patch (3.52 KB, patch)
2013-04-03 21:54 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-04-03 21:51:31 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-04-03 21:54:27 PDT 
Created attachment 196435 [details]
the patch
Comment 2 Geoffrey Garen 2013-04-03 22:05:02 PDT 
Comment on attachment 196435 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196435&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLLVMHeaders.h:36
> +//   headers don't compile clean with our warnings.

Grammar: "cleanly".
Comment 3 Filip Pizlo 2013-04-03 22:08:52 PDT 
Landed in http://trac.webkit.org/changeset/147608