Bug 113863

Summary:

[Qt] Move logic of simple forwarding functions to TestRunner.

Product:

WebKit

Reporter:

Zeno Albisser <zeno>

Component:

New Bugs

Assignee:

Zeno Albisser <zeno>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

113393

Bug Blocks:

Attachments:

Description	Flags
Patch	hausmann: review+

Description Zeno Albisser 2013-04-03 03:28:48 PDT

[Qt] Move logic of simple forwarding functions to TestRunner.

Comment 1 Zeno Albisser 2013-04-03 03:29:30 PDT

Created attachment 196315 [details]
Patch

Comment 2 Simon Hausmann 2013-04-03 03:44:08 PDT

Comment on attachment 196315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196315&action=review

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:833
> +    DumpRenderTree* drt = DumpRenderTree::instance();

Since what we need is the QWebPage and not the drt, you could also declare a local QWebPage *webPage variable instead of *drt

Comment 3 Zeno Albisser 2013-04-03 05:32:14 PDT

Committed r147543: <http://trac.webkit.org/changeset/147543>