Summary: | build-webkit doesn't support some build options | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ed Bartosh <bartosh> | ||||||||||||||||||||||||||||||
Component: | Tools / Tests | Assignee: | Ed Bartosh <bartosh> | ||||||||||||||||||||||||||||||
Status: | UNCONFIRMED --- | ||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | cdumez, dbates, eduk750, gtk-ews, gyuyoung.kim, kalyan.kondapally, laszlo.gombos, mifenton, philn, rakuco, rego+ews, rniwa, webkit.review.bot, xan.lopez | ||||||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||||||||||
Bug Depends on: | 113641, 113951, 114089, 114299 | ||||||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Ed Bartosh
2013-03-31 08:21:48 PDT
Created attachment 195897 [details]
Patch
Comment on attachment 195897 [details] Patch Attachment 195897 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17328596 Comment on attachment 195897 [details] Patch Attachment 195897 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17337421 Created attachment 195899 [details]
Patch
Created attachment 195901 [details]
Patch
Comment on attachment 195901 [details] Patch Attachment 195901 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17344248 Created attachment 195902 [details]
Patch
Created attachment 195903 [details]
Patch
Comment on attachment 195903 [details] Patch Attachment 195903 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17293477 Created attachment 195905 [details]
Patch
Comment on attachment 195905 [details] Patch Attachment 195905 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17382120 Created attachment 195906 [details]
Patch
Comment on attachment 195906 [details] Patch Attachment 195906 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17340917 Comment on attachment 195906 [details] Patch Attachment 195906 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17240731 Created attachment 195908 [details]
Patch
Attachment 195908 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/page/gtk/EventHandlerGtk.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/AccessibilityUIElement.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1
Tools/DumpRenderTree/AccessibilityUIElement.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 195908 [details] Patch Attachment 195908 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17325413 Added dependency to 113641. I'll move all build fixes there or to new bugs. Created attachment 195941 [details]
Patch
Removed all build fixes from the patch. Fixes will be added to dependent bugs.
Comment on attachment 195941 [details] Patch Attachment 195941 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17314748 Created attachment 196728 [details]
Patch
Comment on attachment 196728 [details] Patch Attachment 196728 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17526330 Created attachment 196882 [details]
Patch
Comment on attachment 196882 [details] Patch Attachment 196882 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17562026 Comment on attachment 196882 [details] Patch Attachment 196882 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17490054 Created attachment 197144 [details]
Patch
Comment on attachment 197144 [details] Patch Attachment 197144 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17676041 Comment on attachment 197144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197144&action=review > Tools/Scripts/webkitperl/FeatureList.pm:524 > + { option => "view-mode-css-media", desc => "Toggle Track support for the view-mode media Feature support", > + define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport }, Why is this default 1? I don't think Mac enables this feature by default. r-. I took default values of all options from Source/cmake/WebKitFeatures.cmake. By default ENABLE_VIEW_MODE_CSS_MEDIA is enabled there: WEBKIT_OPTION_DEFINE(ENABLE_VIEW_MODE_CSS_MEDIA "Toggle Track support for the view-mode media Feature" ON) Created attachment 201186 [details]
Patch
Comment on attachment 201186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201186&action=review > Tools/Scripts/webkitperl/FeatureList.pm:525 > + define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport }, You did not take rniwa's feedback into consideration. As far as I know, EFL, BlackBerry and GTK and the only ports enabling this. This should therefore probably be (isEfl() || isGtk() || isBlackBerry()) instead of 1. You need to do similar checks for all the features or you are likely to break other ports. Not all the ports are using CMake and even those using CMake may override the default valye in WebKitFeatures.cmake. Christophe, thank you for the explanations. Now I started to understand where I'm wrong with this patch. I was actually taking Niwa's comment into consideration, but didn't understand the whole thing. I've submitted patch again just to see where it'll break the build. Comment on attachment 201186 [details] Patch Attachment 201186 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/277084 Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me. (In reply to comment #34) > Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me. I work mostly on EFL port so this is not 100% clear for me either. My current guess is: - mac: Source/WebCore/Configurations/FeatureDefines.xcconfig - EFL: Source/cmake/OptionsEfl.cmake -> Source/cmake/WebKitFeatures.cmake - BlackBerry: Source/cmake/OptionsBlackBerry.cmake -> Source/cmake/WebKitFeatures.cmake - GTK: Source/autotools/SetupWebKitFeatures.m4 - Qt: I think it is using build-webkit only Created attachment 201471 [details]
Patch
Christophe, thank you! I looked into all those files and set up defaults accordingly. Comment on attachment 201471 [details] Patch Attachment 201471 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/375257 |