Bug 113644

Summary: Gradient background does not get repainted when child box is expanded.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Major CC: allan.jensen, eric, esprehn+autocc, koivisto, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
Patch none

Description zalan 2013-03-30 14:03:22 PDT
Created attachment 195872 [details]
test case

When parent box has gradient background and child box height changes (expand), only expanded area gets invalidated.
Gradient looks broken until the next repaint.

see attached test case.
Comment 1 zalan 2013-03-30 14:11:31 PDT
<rdar://problem/13048858>
Comment 2 Allan Sandfeld Jensen 2013-03-30 16:17:01 PDT
This sounds like it also part the same problem as in bug 113313. The gradient is not only broken because the top is not repainted, but the bottom is also painted wrong (with the full gradient) because partial repaint is not working.
Comment 3 zalan 2013-03-30 23:53:16 PDT
(In reply to comment #2)
> This sounds like it also part the same problem as in bug 113313. The gradient is not only broken because the top is not repainted, but the bottom is also painted wrong (with the full gradient) because partial repaint is not working.

Thanks for the headsup. I'll check, though this test case is fixed simply by issuing repaint for the parent box. Patch is coming up.
Comment 4 zalan 2013-03-31 10:11:58 PDT
Created attachment 195898 [details]
Patch
Comment 5 Antti Koivisto 2013-03-31 14:52:51 PDT
Comment on attachment 195898 [details]
Patch

cool r=me
Comment 6 WebKit Review Bot 2013-03-31 22:52:34 PDT
Comment on attachment 195898 [details]
Patch

Clearing flags on attachment: 195898

Committed r147303: <http://trac.webkit.org/changeset/147303>
Comment 7 WebKit Review Bot 2013-03-31 22:52:38 PDT
All reviewed patches have been landed.  Closing bug.